Skip to content

Conversation

@wideawakening
Copy link
Contributor

@wideawakening wideawakening commented Dec 5, 2023

enables agentless host scanner module for CA (somes steps are done manually from sysdig)
to be released w50

@wideawakening wideawakening changed the title feat: agentless host scanner feat: agentless host scanner [SSPROD-33067] Dec 5, 2023
@wideawakening wideawakening marked this pull request as ready for review December 5, 2023 08:33
@nkraemer-sysdig nkraemer-sysdig requested a review from a team December 11, 2023 16:59
Copy link
Contributor

@cgeers cgeers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @wideawakening Since this module is invoked by, and interacts with a completely separate system, perhaps a CODEOWNERS update to unblock future maintenance efforts is also warranted here.

@wideawakening
Copy link
Contributor Author

will try work on that tomorrow.
is there anything else to review? otherwise, can we do it optionally and have an approval? thanks!

@acaprari
Copy link

@cgeers if you don't mind, let's address the change to the CODEOWNERS for later, since we need to create a team under sysdiglabs for agentless.

If the changes are ok, we can merge this PR and open a new one specific for CODEOWNERS as soon as we are ready

Thank you

@wideawakening wideawakening merged commit a982d1d into master Dec 12, 2023
@wideawakening wideawakening deleted the feat-agentless-scanner branch December 12, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants