Skip to content

Add create and list notification channels#83

Merged
davideschiera merged 2 commits intosysdiglabs:masterfrom
meskio:notification_channels
Mar 14, 2019
Merged

Add create and list notification channels#83
davideschiera merged 2 commits intosysdiglabs:masterfrom
meskio:notification_channels

Conversation

@meskio
Copy link
Contributor

@meskio meskio commented Feb 28, 2019

No description provided.

Copy link
Contributor

@figarocorso figarocorso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we add an example for these new endpoints? This way this code would be tested.

Besides that, code looks good.

@meskio
Copy link
Contributor Author

meskio commented Mar 6, 2019

Example added.

@davideschiera davideschiera merged commit 2c12210 into sysdiglabs:master Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants