Consolidate and simplify tests using Sysdig agent#79
Merged
davideschiera merged 7 commits intomasterfrom Feb 21, 2019
Merged
Conversation
Contributor
davideschiera
commented
Feb 20, 2019
davideschiera
commented
- Use a single command line to launch Sysdig agent container
- Wait longer after the launch, to make data is made available via Sysdig API
- Simplify test for policy events (wait longer instead of polling)
1. Use a single command line to launch Sysdig agent container 2. Wait longer after the launch, to make data is made available via Sysdig API 3. Simplify test for policy events (wait longer instead of polling)
mstemm
approved these changes
Feb 21, 2019
Contributor
mstemm
left a comment
mstemm
left a comment
There was a problem hiding this comment.
Nice change to start the agent for both the monitor and secure side! Also consolidates into a single docker run command.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.