Add support for Sysdig Secure compliance tasks#77
Merged
davideschiera merged 7 commits intosysdiglabs:masterfrom Feb 20, 2019
meskio:compliance
Merged
Add support for Sysdig Secure compliance tasks#77davideschiera merged 7 commits intosysdiglabs:masterfrom meskio:compliance
davideschiera merged 7 commits intosysdiglabs:masterfrom
meskio:compliance
Conversation
omerazr
approved these changes
Feb 17, 2019
figarocorso
reviewed
Feb 20, 2019
Contributor
figarocorso
left a comment
There was a problem hiding this comment.
LGTM besides a couple of comments. Nice work, thank you for the refactor.
sdcclient/_secure.py
Outdated
| if scope is not None: | ||
| task["scope"] = scope | ||
| if enabled is not None: | ||
| task["enabled"] = enabled |
Contributor
There was a problem hiding this comment.
I've seen this a couple of times at the code. Would this be worthy?
options = {
'name': name,
'moduleName': module_name,
...
}
for key, value in options.items():
if value is not None:
task[key] = value
Contributor
Author
There was a problem hiding this comment.
I'm not sure how readable are dict completions, but this is a try: 33e82b2
Contributor
There was a problem hiding this comment.
Yeah, totally right. Wasn't sure at all, but wanted to know your opinion ;-)
Let's keep python2 compatibility.
omerazr
approved these changes
Feb 20, 2019
Contributor
|
@meskio unfortunately this time the build was failing for real: Would you mind taking a look and see if you can file another PR to fix the test (or code)? Let me know if you need any help. Thanks! |
Contributor
Author
|
Ouch, I thought I tested. I'm looking into that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As well as adding support to fetch policy events by id.