fix: declare sphinx-rtd-theme in docs extras#253
Merged
nenper merged 1 commit intosysdiglabs:masterfrom Oct 2, 2024
Merged
Conversation
Currently sphinx-rtd-theme is incorrectly being included in the main group dependencies and hence pulls in itself and sphinx as a runtime dep for the client. Declaring it in the docs group ensures it is only installed if the `sdcclient[docs]` is installed. Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
Contributor
Author
|
@nenper 👋🏻 please can you take a look at this small PR? |
Contributor
Author
|
@nenper thank you! |
Contributor
Author
|
@nenper if possible, please could you also arrange for a release version to be cut and uploaded to PyPi with this change? |
Contributor
Author
|
@nikola-milikic 🎉 thanks! I see v0.18.0 was released and also pushed to pypi too, that's great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently sphinx-rtd-theme is incorrectly being included in the main group dependencies and hence pulls in itself and sphinx as a runtime dep for the client. Declaring it in the docs group ensures it is only installed if the
sdcclient[docs]is installed.Not only does this pull in a number of unnecessary dependencies, it also forces a backlevel urllib3 1.x to be used. Here's the before and after this PR of a
pip install sdcclientinto an empty venv: