Conversation
…_policies() call for policies v1
Since we cannot control whether the agent is able to create captures or not, and it's not our duty verify that, but offer a Python API for the Backend API, we are disabling these tests but maintaining them for future reference.
…st for policies v1
BREAKING CHANGE: Splits the SdMonitorClient into a DashboardClient's, both from version v2 and v3. By default now SdMonitorClient inherits from DashboardClientV3 and therefore implements all the interface, but the following methods have changed the signature: - add_dashboard_panel - remove_dashboard_panel This is required because the Dashboards V3 do not implement the same kind of panels as V2 implemented. Signed-off-by: Federico Barcelona <fede_rico_94@hotmail.com>
Contributor
|
Is a bit big, but is well built. I love how you are getting familiar with testing :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
Splits the SdMonitorClient into a DashboardClient's, both from version v2 and v3. By default now SdMonitorClient inherits from DashboardClientV3 and therefore implements all the interface, but the following methods have changed the signature:
This is required because the Dashboards V3 do not implement the same kind of panels as V2 implemented.