Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pytest-rerunfailures compatibility #881

Merged
merged 1 commit into from
Aug 23, 2024
Merged

fix: pytest-rerunfailures compatibility #881

merged 1 commit into from
Aug 23, 2024

Conversation

noahnu
Copy link
Collaborator

@noahnu noahnu commented Aug 23, 2024

Closes #879

TODO: We likely need a test that leverages pytest-rerunfailures directly. Maybe we should introduce a set of e2e tests with a number of different plugins and merge test coverage.

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #881      +/-   ##
==========================================
- Coverage   98.11%   97.99%   -0.13%     
==========================================
  Files          21       21              
  Lines        1595     1598       +3     
==========================================
+ Hits         1565     1566       +1     
- Misses         30       32       +2     

@noahnu noahnu merged commit 16911ad into main Aug 23, 2024
16 of 18 checks passed
@noahnu noahnu deleted the bugfix/879 branch August 23, 2024 04:47
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 70aac83 Previous: 6585004 Ratio
benchmarks/test_1000x.py::test_1000x_reads 0.795888178453973 iter/sec (stddev: 0.0572234928209951) 0.8037333691481231 iter/sec (stddev: 0.06761379188854093) 1.01
benchmarks/test_1000x.py::test_1000x_writes 0.7025032009375699 iter/sec (stddev: 0.17992382872860163) 0.7037112245574709 iter/sec (stddev: 0.15599291095307652) 1.00
benchmarks/test_standard.py::test_standard 0.7452105320594957 iter/sec (stddev: 0.0653980644907155) 0.7411016518653493 iter/sec (stddev: 0.06701876580278031) 0.99

This comment was automatically generated by workflow using github-action-benchmark.

noahnu pushed a commit that referenced this pull request Aug 23, 2024
## [4.7.1](v4.7.0...v4.7.1) (2024-08-23)

### Bug Fixes

* pytest-rerunfailures compatibility ([#881](#881)) ([16911ad](16911ad))
@noahnu
Copy link
Collaborator Author

noahnu commented Aug 23, 2024

🎉 This PR is included in version 4.7.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

syrupy 4.6.3+ is incompatible with pytest-rerunfailures
1 participant