fix: exit serialization early on detection of a cycle #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #78 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 14 14
Lines 527 540 +13
=====================================
+ Hits 527 540 +13
Continue to review full report at Codecov.
|
noahnu
reviewed
Dec 29, 2019
src/syrupy/serializers/amber.py
Outdated
| @@ -89,7 +92,9 @@ def object_type(cls, data: "SerializableData") -> str: | |||
| return f"<class '{data.__class__.__name__}'>" | |||
|
|
|||
| @classmethod | |||
| def serialize_string(cls, data: "SerializableData", indent: int = 0) -> str: | |||
| def serialize_string( | |||
| cls, data: "SerializableData", *, indent: int = 0, visited: List[Any] = [] | |||
There was a problem hiding this comment.
we can remove the unused visited kwarg if we do **_, not sure how mypy handles that though?
There was a problem hiding this comment.
I think it complained last I tried, will attempt again but treating as non blocking
There was a problem hiding this comment.
Too much refactoring needed to satisfy mypy and ignore the argument, leaving as is
noahnu
approved these changes
Dec 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tracks visited items in serialization and exits early when cycle is encountered or max depth exceeded
Related Issues
Checklist
Additional Comments