Ensure that untouched snapshots are not deleted in targeting mode #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahnu
reviewed
Jan 31, 2020
noahnu
reviewed
Jan 31, 2020
Codecov Report
@@ Coverage Diff @@
## master #123 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 16 16
Lines 705 715 +10
=========================================
+ Hits 705 715 +10 |
noahnu
reviewed
Feb 5, 2020
noahnu
reviewed
Feb 7, 2020
mcataford
commented
Feb 7, 2020
CHANGELOG.md
Outdated
| @@ -10,6 +10,10 @@ From v1.0.0 onwards, this project adheres to [Semantic Versioning](https://semve | |||
|
|
|||
| - Up to date with releases. | |||
|
|
|||
| ## [v0.3.2](https://github.com/tophat/syrupy/compare/v.0.3.1...v0.3.2) | |||
There was a problem hiding this comment.
@noahnu Is this the correct way to go about writing out the changelog manually?
mcataford
changed the title
iamogbz
reviewed
Feb 7, 2020
iamogbz
reviewed
Feb 7, 2020
iamogbz
reviewed
Feb 7, 2020
iamogbz
reviewed
Feb 7, 2020
iamogbz
reviewed
Feb 7, 2020
iamogbz
reviewed
Feb 7, 2020
noahnu
reviewed
Feb 7, 2020
|
@all-contributors please add @mcataford for code, test |
|
I've put up a pull request to add @mcataford! 🎉 |
iamogbz
reviewed
Feb 9, 2020
|
|
||
| target_snaps = {snap.location for snap in self.used} | ||
|
|
||
| return item.location in target_snaps |
There was a problem hiding this comment.
I think item.location in self.used would have just worked here without needing to create target_snaps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds some handling around filenames that can be passed to
pytestto target testfiles. Previously, passing in file paths would run the tests on these paths, and consider snapshots that weren't touched as unused -- even though they were actually used by other tests not targeted bypytestin that instance.By passing down a list of targeted files and using a filtering function, this takes out snapshots that aren't related to the targeted files, if
pytestis passed some paths. This way,syrupyno longer purges snapshots by mistake.Related Issues
This addresses #119.
Checklist