Open
Conversation
Kurshith
commented
Mar 14, 2019
Kurshith
commented
- Fixed broken spinner image by including the image path
Collaborator
|
Hey Kurshith, thanks for this. I think we're going to leave this broken for a little while longer, while finishing up @syr/pack in the next few days. It will have a media strategy built in. Currently, we're relying on Webpack which just isn't really geared toward the problems we're trying to solve. Hopefully moving to our own packer that can be positioned to support a tri-platform distribution approach, along with a built-in dependency tree model will give us a bunch of gains. I'll hold this PR open just in case though. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.