Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link in sys_file_reference.link is falsely displayed as broken link if in format <page uid>#<content element uid> #382

Closed
sypets opened this issue Sep 10, 2024 · 2 comments · Fixed by #404 or #405

Comments

@sypets
Copy link
Owner

sypets commented Sep 10, 2024

Describe the bug

sys_file_reference.link are now checked by default. If they contain a working link of the format e.g. 95476#684043, this is displayed as "page not found".

Something like this works though: t3://page?uid=95476#684043

Also, if there is a not working link to a CE in header_link, the CE id is incorrectly displayed as "Link to page", e.g.

header_link contains: t3://page?uid=108222#999999999

  • page uid 108222 exists
  • CE uid 999999999 does not exist
  • problem: it is correctly found as broken, but in link list the "link target" shows the CE as "Link to page: [999999999]"

image

Important: the behaviour appears to be different between v12 and v13!

To Reproduce
Steps to reproduce the behavior:

  1. Create a "Text & Media" with a file reference
  2. For the file enter a link, use the format pageid#ce-id
  3. check links
  4. Link is displayed as broken

Expected behavior
The link should not be displayed in broken link list (if ok)

Screenshots

image

System (please complete the following information):

  • TYPO3 version: 12.4.19
  • brofix version: latest main
  • installed with Composer: yes

Additional todos

  • should also check if reproducible with linkvalidator. If yes, create issue
@sypets
Copy link
Owner Author

sypets commented Sep 10, 2024

Additionally, 2 entries are display, switch to
image
in form

@sypets
Copy link
Owner Author

sypets commented Sep 11, 2024

Problem also exists in linkvalidator in TYPO3 13: https://forge.typo3.org/issues/104387

But I did not see the 2 entries for one link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant