Skip to content

Refactored several functions, new documentation and support for new parameters #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

panikon
Copy link

@panikon panikon commented Aug 9, 2019

Good afternoon,
I'm not sure if these changes can be of any use to the project, I made most of them when I was studying the current codebase.

Heavily modified tinyobj version

  • Fully documented using NaturalDocs
  • No limit to number of supported faces
  • Revamped command structure
  • Refactored several functions
  • All supported 'objects' have their own structure
  • tinyobj_attrib_t not compatible with older versions, use COMPATtinyobj_attrib_t instead
  • Added more error return codes
  • Correctly identifies unknown commands
  • UTHash support

New feature support:

  • Added point (p) and line (l) support
  • Added Parameter space vertex (vp) support
  • Smoothing groups (s) support

panikon added 5 commits August 8, 2019 23:12
- Fully documented using NaturalDocs
- No limit to number of supported faces
- Revamped command structure
- Refactored several functions
- All supported 'objects' have their own structure
- tinyobj_attrib_t not compatible with older versions, use COMPATtinyobj_attrib_t instead
- Added more error return codes
- Correctly identifies unknown commands
- UTHash support
New feature support:
- Added point (p) and line (l) support
- Added Parameter space vertex (vp) support
- Smoothing groups (s) support
Updated older tests to support new structures
CMake support

Added unit tests for the new attribute handling
Updated older tests to support new structures
CMake support

.
Fixed mmap_file support for windows
Removed redundant unistd inclusion
Added generated documentation
@syoyo
Copy link
Owner

syoyo commented Aug 9, 2019

Super awesome! Changes are a lot, so require some time to review it.

@syoyo
Copy link
Owner

syoyo commented Aug 15, 2019

It looks code itself works file, but I got some Makefile error in Linux environment.

Also, -ansi does not work well for C99 code in gcc(we need to use -std=c99 solely).

https://gcc.gnu.org/onlinedocs/gcc/Standards.html

What is your compiler/os environment?

@panikon
Copy link
Author

panikon commented Aug 16, 2019

I didn't test the code in Linux environment and don't recall changing the Makefile, maybe the error is related to the way that CMake generates new makefiles?
I'm currently in Windows 7 64bit and tested using msvc 10 and 19.

@syoyo
Copy link
Owner

syoyo commented Aug 16, 2019

I'm currently in Windows 7 64bit and tested using msvc 10 and 19.

I see. Makefile was the existing one(contributed by someone, not me). I will refactor Makefile and CMakeLists so that it runs on Linux and macOS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants