Fix protocol 6 (Beepwear Pro) setting time 1 hour fast in daylight savings time #314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #309!
This PR fixes a bug where the time on the Beepwear Pro (protocol 6) would be set one hour fast for a time in daylight savings time 🐛
To determine time zone, the UTC offset is used, which adds one hour during daylight savings. Due to this, some small logic was added to remove one hour from the UTC offset in daylight savings prior to looking up the protocol 6 time zone for the offset. The time on the watch naively followed this pattern also, when it didn't need to, which caused this bug.