Skip to content

Conversation

@dstallenberg
Copy link
Contributor

@dstallenberg dstallenberg commented Jan 16, 2023

If applied correctly the PR will:

  • Move test case specific code out of the core
  • Update the solc compiler
  • Allow for solc compiler version picking through the configuration
  • Update the CI infrastructure settings
  • Add code owners file
  • Update @syntest/framework to @syntest/core
  • Update and lock dependency versions
  • Specify config files in the scripts section of the package.json
  • Fix linting and formatting errors
  • Configure the new pipeline stage "verify"

dstallenberg and others added 6 commits December 15, 2022 10:35
The framework contained some residual classes related to the specific tool (in this case Solidity). This commit moves these over.
The license year was outdated.
The SOLC compiler was outdated and did not allow newer version of Solidity to be compiled
Previously the SOLC compiler only supported one version as the version was manually defined. This commit requires the user to specify the version on the CLI
- The CI was only running on the main, but we now added a develop branch
- The CI was not using the latest Node.JS version
Now the developer team is growing it is useful to have code owners defined so that PRs are always reviewed by at least one code owner.
@dstallenberg dstallenberg marked this pull request as draft January 16, 2023 12:45
dstallenberg and others added 9 commits January 16, 2023 14:40
* Replace @syntest/framework with @syntest/core in all files
* Resolve breaking changes
* Lock @syntest/core version
The CI was only running on the main, but we now added a develop branch
The CI was not using the latest Node.JS version
* Lock and update some dependencies
* Remove ganache dependency
* Fix formatter errors
* Fix eslint errors
* Modify build workflow
* Configure  verify workflow
* Add husky to prevent unlinted/unformatted commits or code
@mitchellolsthoorn mitchellolsthoorn marked this pull request as ready for review January 17, 2023 17:16
@mitchellolsthoorn mitchellolsthoorn marked this pull request as draft January 17, 2023 17:16
* chore: bump version
* chore: update changelog
@mitchellolsthoorn mitchellolsthoorn marked this pull request as ready for review January 18, 2023 09:38
@mitchellolsthoorn mitchellolsthoorn merged commit 6b5e939 into main Jan 18, 2023
@dstallenberg dstallenberg deleted the develop branch February 2, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants