Skip to content

Conversation

@mitchellolsthoorn
Copy link
Member

@mitchellolsthoorn mitchellolsthoorn commented Aug 2, 2023

This PR adds a constant pool to the JavaScript testing module. It searches for constants in the context root and stores these in a pool. This pool is then used for seeding the sampler.

@mitchellolsthoorn mitchellolsthoorn requested a review from a team as a code owner August 2, 2023 10:59
@mitchellolsthoorn mitchellolsthoorn linked an issue Aug 2, 2023 that may be closed by this pull request
2 tasks
Copy link
Contributor

@dstallenberg dstallenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we only need to edit the decoder to make sure we do not use invalid characters.

@mitchellolsthoorn mitchellolsthoorn mentioned this pull request Aug 2, 2023
Copy link
Contributor

@dstallenberg dstallenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@dstallenberg dstallenberg merged commit 02f0aaf into main Aug 2, 2023
@dstallenberg dstallenberg deleted the feat-constant-pool branch August 2, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Constantpool

4 participants