Skip to content

Themability of font-related properties? #1

@scottyeck

Description

@scottyeck

I don't quite understand why, but font-related properties (eg. font-family, font-size, line-height etc.) seem to be the only ones that are not themable once this partial is imported. There are more than likely plenty of scenarios (my own being one of them, as it just so happens 😄 ), wherein a user may prefer a different font-size or a different (although likely still monospaced) font-family.

Was there a reason for their exclusion?

FWIW, I suppose I should probably provide a little context for my use case.

I understand that this module is shipped alongside syntaxhighlighter. I've chosen to work with node-syntaxhighlighter (as it is syntactically somewhat lighter and as such better suited for my application), but this package ships only with CSS. As such, I've taken advantage of the standalone theming partial you've provided here for use with the main package.

Aside from the font issue discussed above, I think this seems to be a pretty solid plan. Including font-properties will enhance the abilities of this module as a standalone as well as create flexibility for any themes built for syntaxhighlighter in the future.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions