Fix for double/single quote strings in powershell brush and updated verbs and keywords #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a bug with empty double quoted strings ("") which would bleed ignoring the closing quote.
Fixed a bug where double quoted strings ending in "`" would incorrectly show as closed strings.
Update brush-powershell.js
|
Please make this change to fix the bug mentioned in the second commits comment. |
Used "Get-Verb" to gather all the approved verbs and removed any not "approved"
Removed last space from the verbs variable. Updated Keywords variable
|
Latest commits will update verbs and keywords. |
MarlonRodriguez
changed the title
|
Thank you! I'll merge this shortly. |
|
np. Seems like it might be a bit obsolete now that you are gearing up v4 dev merge? I took a quick look and your use of XRegEx will mean a redo of this repo as well. |
|
Is there a reason this never got merged? I was about to make these changes myself and make a PR but I see the work has already been done. |
|
I think it was the fact that the new version treats it differently with different syntax and this might be different. Since I didn't have the new dev branch of v4 I didn't dig in it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug with empty double quoted strings ("") which would bleed ignoring the closing quote.
Fixed a bug where double quoted strings ending in "`" would incorrectly show as closed strings.