Add improved parents type
#11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, a basic `Parent` from `@types/unist` was used, as an array, for the second parameter of a visitor (`parents`). This changes that to instead use an array of descendants in `tree` which implement the abstract `Parent` interface. This is not perfect, because several parents can’t be found in certain nodes practically, but it will at least help folks narrow. Related to syntax-tree/unist-util-visit#30.
wooorm
added
🦋 type/enhancement
This comment has been minimized.
This comment has been minimized.
wooorm
changed the title
parents type
|
Fixed! |
|
A bit annoying that |
github-actions
bot
removed
👍 phase/yes
|
Hi! This was closed. Team: If this was merged, please describe when this is likely to be released. Otherwise, please add one of the |
wooorm
added a commit
to syntax-tree/unist-util-visit
that referenced
this pull request
Sep 21, 2021
Previously, a basic `Parent` from `@types/unist` was used for the third parameter of a visitor (`parent`). This changes that to instead use an array of descendants in `tree` which implement the abstract `Parent` interface and can have `node` as a child. Closes GH-30. Related-to: syntax-tree/unist-util-visit-parents#11.
5 tasks
wooorm
added a commit
to syntax-tree/unist-util-visit
that referenced
this pull request
Sep 23, 2021
Previously, a basic `Parent` from `@types/unist` was used for the third parameter of a visitor (`parent`). This changes that to instead use an array of descendants in `tree` which implement the abstract `Parent` interface and can have `node` as a child. Closes GH-30. Closes GH-31. Related-to: syntax-tree/unist-util-visit-parents#11.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial checklist
Description of changes
Previously, a basic
Parentfrom@types/unistwas used, as an array, for the second parameter of a visitor (parents). This changes that to instead use an array of descendants intreewhich implement the abstractParentinterface. This is not perfect, because several parents can’t be found in certain nodes practically, but it will at least help folks narrow.Related to syntax-tree/unist-util-visit#30.
/cc @crossjs