Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove element when label is not provided #28

Merged
merged 1 commit into from
Dec 14, 2024
Merged

Conversation

tfirdaus
Copy link
Member

@tfirdaus tfirdaus commented Dec 14, 2024

This Pull Request adds new logic in the CheckboxGroup component that handles the element for the label. If the label is not provided, it now will not render the element in the DOM.

@tfirdaus tfirdaus merged commit 0d512e0 into main Dec 14, 2024
4 checks passed
@tfirdaus tfirdaus deleted the fix/checkbox-group-label branch December 14, 2024 06:14
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.11%. Comparing base (9612011) to head (555290b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #28   +/-   ##
=======================================
  Coverage   94.11%   94.11%           
=======================================
  Files          55       55           
  Lines        1682     1682           
  Branches       38       38           
=======================================
  Hits         1583     1583           
  Misses         66       66           
  Partials       33       33           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants