pdf: some TPdfWrite internal refactoring

- no functional change, made code cleaner to avoid any potential buffer overflow
synopse · Jan 16, 2025 · 1189d7e · 1189d7e
1 parent baef721
commit 1189d7e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/mormot.commit.inc b/src/mormot.commit.inc
@@ -1 +1 @@
-'2.3.9404'
+'2.3.9405'
diff --git a/src/ui/mormot.ui.pdf.pas b/src/ui/mormot.ui.pdf.pas
@@ -4871,14 +4871,14 @@ function TPdfWrite.AddEscapeText(Text: PAnsiChar; Font: TPdfFont): TPdfWrite;
 
 function TPdfWrite.AddHex(const Bin: PdfString): TPdfWrite;
 var
-  L, len: integer;
+  L, len: PtrInt;
   PW: pointer;
 begin
   len := length(Bin);
   PW := pointer(Bin);
   repeat
     L := len;
-    if BEnd - B <= L * 2 then
+    if PtrInt(BEnd - B) <= L * 2 then // note: PtrInt(BEnd - B) could be < 0
     begin
       Save;
       if L > high(fTmp) shr 1 then
@@ -5039,7 +5039,7 @@ function TPdfWrite.AddUnicodeHex(PW: PWideChar; WideCharCount: integer): TPdfWri
   end;
 
 var
-  L: integer;
+  L: PtrInt;
   {$ifdef USE_PDFSECURITY}
   sectmp: TSynTempBuffer;
   {$endif USE_PDFSECURITY}