Skip to content
This repository was archived by the owner on Oct 24, 2022. It is now read-only.

Conversation

Jasonvdb
Copy link
Contributor

@Jasonvdb Jasonvdb commented Apr 9, 2021

  • Improved the example app to demo more LND functions
  • Exporting backups
  • Subscribing to backup updates so app knows when to backup a new channel state
  • Backup verification
  • Native refactoring for both Swift and Java to not use protobuf for request/responses. All logic for decoding/encoding moved to typescript so any changes to the API going forward likely won't require any native updates. We also only need to maintain files generated from protos in typescript now instead of in 3 places.

Simulator Screen Shot - iPhone 11 - 2021-04-09 at 18 14 18

@Jasonvdb Jasonvdb requested a review from coreyphillips April 9, 2021 16:21
@coreyphillips
Copy link
Collaborator

Receiving the following error:
error: Error: Unable to resolve module ./walletunlocker from /spectrum/node_modules/react-native-lightning/src/lnd.ts:

Looks like it's coming from this line specifically.

@Jasonvdb
Copy link
Contributor Author

Did you run yarn build? It should be building the missing protobuf walletunlocker.d.ts file from the .proto 🤔

@coreyphillips
Copy link
Collaborator

I did, but it still seems to throw the same error. Going to experiment with the local build and see what's going on.

@Jasonvdb
Copy link
Contributor Author

Ok committed the walletunlocker.d.ts for now. You'll still need to go into react-native-lightning and yarn build though

@coreyphillips coreyphillips merged commit 1490445 into master Apr 12, 2021
@coreyphillips coreyphillips deleted the backup-options branch April 12, 2021 13:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants