fix: gets peer message when manual open channel fails #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ovitrif
previously approved these changes
Sep 20, 2024
There was a problem hiding this comment.
Approved with some suggestions, initially I was only interested in cleaning up that part of the Kotlin code, but then I thought "the more the 2 sources are alike, the easier to maintain" so I sought a way to align the code doing the same in Swift if the Kotlin one gets updated 👍🏻
pwltr
previously approved these changes
Sep 23, 2024
pwltr
previously approved these changes
Sep 25, 2024
pwltr
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
channelManager.createChannelwhen possiblepeer_messagetochannel_manager_channel_closedevent when existslm.createChannel(...)returns peer message as the error string if it exists