Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement Auth For Testing #2237

Merged
merged 13 commits into from
Sep 25, 2024
Merged

feat: Implement Auth For Testing #2237

merged 13 commits into from
Sep 25, 2024

Conversation

coreyphillips
Copy link
Collaborator

@coreyphillips coreyphillips commented Sep 17, 2024

Description

  • Adds react-native-pubky as a dependency.
  • Implements auth from react-native-pubky.
  • Adds enough of the UI to test scanning a pubky auth url and confirm the authorization.

QA Notes

  • Scan the following qrcode and press authorize:
Screenshot 2024-09-18 at 8 27 15 AM
  • URL: pubkyauth:///?caps=/pub/pubky.app/:rw,/pub/foo.bar/file:r&secret=U55XnoH6vsMCpx1pxHtt8fReVg4Brvu9C0gUBuw-Jkw&relay=http://167.86.102.121:4173/

    • If the url no longer works please feel free to ask me for another or you can generate one in rust using:
      • match client.auth_request("http://167.86.102.121:5173/", &capabilities)

Type of change

  • New feature (non-breaking change which adds functionality)

Tests

  • No test
Simulator.Screen.Recording.-.iPhone.15.-.2024-09-17.at.21.59.14.mp4

Implements auth from react-native-pubky
@coreyphillips coreyphillips added the enhancement New feature or request label Sep 17, 2024
@coreyphillips coreyphillips self-assigned this Sep 17, 2024
Copy link

socket-security bot commented Sep 17, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

Updates react-native-pubky to 0.2.2.
Adds success circle to successful auth events.
@coreyphillips coreyphillips marked this pull request as ready for review September 18, 2024 12:31
@coreyphillips coreyphillips requested a review from pwltr September 18, 2024 12:31
@coreyphillips coreyphillips changed the title feat: Implement Auth feat: Implement Auth For Testing Sep 18, 2024
@coreyphillips
Copy link
Collaborator Author

coreyphillips commented Sep 18, 2024

Not sure what to do about the tests until we make the pubky repos public.

@pwltr
Copy link
Collaborator

pwltr commented Sep 19, 2024

Maybe try pulling from Github for now? "@synonymdev/react-native-pubky": "pubky/react-native-pubky"

But I think the repo is missing some files in the .yarn folder as well. Check the .gitignore for what should be committed.

@coreyphillips
Copy link
Collaborator Author

No luck there. I'm happy to just keep this branch up-to-date and merge it in once we go public.

@limpbrains
Copy link
Collaborator

We are using yarn, does npmrc work for it ?

Adds getPrivateKeyFromPath.
Updates getPrivateKey to use getPrivateKeyFromPath.
Updates getPubkySecretKey to use getPrivateKeyFromPath.
Updates PubkyAuth.tsx.
Updates @synonymdev/react-native-pubky dependency.
Updates @synonymdev/react-native-pubky version to 0.2.3.
Copy link

socket-security bot commented Sep 20, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@synonymdev/react-native-pubky@0.3.0 None 0 0 B

🚮 Removed packages: npm/unbox-primitive@1.0.2

View full report↗︎

@coreyphillips coreyphillips marked this pull request as draft September 20, 2024 17:10
Updates @synonymdev/react-native-pubky version to 0.3.0.
@limpbrains limpbrains force-pushed the pubky-auth branch 3 times, most recently from e21c684 to 8ffecf5 Compare September 25, 2024 03:03
@coreyphillips coreyphillips marked this pull request as ready for review September 25, 2024 11:43
@coreyphillips coreyphillips merged commit 61a8f6e into master Sep 25, 2024
7 checks passed
@coreyphillips coreyphillips deleted the pubky-auth branch September 25, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants