Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update button pressed style #2069

Merged
merged 2 commits into from
Jul 17, 2024
Merged

fix: update button pressed style #2069

merged 2 commits into from
Jul 17, 2024

Conversation

pwltr
Copy link
Collaborator

@pwltr pwltr commented Jul 17, 2024

Description

  • add small js dependency color to calculate lightened color (for onPress state)
  • update <Button />s to lighten on active state
  • unify activeOpacity for <TouchableOpacity />
  • add android_ripple for some buttons

Todo: Primary buttons should use blur on iOS, android_ripple on Android

Linked Issues/Tasks

#1864

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (improving code without creating new functionality)

Tests

  • Detox test
  • Unit test
  • No test

Screenshot / Video

Simulator.Screen.Recording.-.iPhone.15.-.2024-07-17.at.13.31.11.mp4

Copy link

socket-security bot commented Jul 17, 2024

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

@pwltr pwltr force-pushed the fix/button-pressed branch from d4e85f7 to 41c696a Compare July 17, 2024 11:35
@pwltr pwltr requested a review from limpbrains July 17, 2024 11:44
@pwltr pwltr merged commit 60502c3 into master Jul 17, 2024
7 checks passed
@pwltr pwltr deleted the fix/button-pressed branch July 17, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants