Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): update bottom-sheets #1899

Merged
merged 1 commit into from
May 29, 2024
Merged

fix(ui): update bottom-sheets #1899

merged 1 commit into from
May 29, 2024

Conversation

pwltr
Copy link
Collaborator

@pwltr pwltr commented May 28, 2024

Description

Updates bottom-sheet layout using common BottomSheetScreen component and adds transferFailed sheet (currently not used).

From design prototype v48:

  • Update modal: Updated visual design and layout.
  • Forced update: Updated visual design and layout.
  • Force transfer modal: Updated visual design and layout.
  • Transfer failure modal: Updated visual design and layout.
  • Transfer failure modal: Changed graphic to 3D ‘X’ icon.
  • High balance modal: Updated visual design and layout.

Linked Issues/Tasks

#1864

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (improving code without creating new functionality)

Tests

  • Detox test
  • Unit test
  • No test

Screenshot / Video

Simulator Screenshot - iPhone 15 - 2024-05-28 at 19 06 36

QA Notes

Tested on various Android devices to confirm no regression for #1839

@pwltr pwltr self-assigned this May 28, 2024
@pwltr pwltr requested a review from limpbrains as a code owner May 29, 2024 09:06
@pwltr pwltr merged commit daad467 into master May 29, 2024
6 checks passed
@pwltr pwltr deleted the fix/modals branch May 29, 2024 09:48
@catch-21
Copy link
Contributor

Tested on 6c75bd0. Checks some of the models and other UI elements on a couple of devices with different display proportions. All good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants