Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: various fixes #1786

Merged
merged 6 commits into from
May 6, 2024
Merged

fix: various fixes #1786

merged 6 commits into from
May 6, 2024

Conversation

pwltr
Copy link
Collaborator

@pwltr pwltr commented May 3, 2024

Description

  • fix(receive): [Bug]: Onchain receive sheet flashes purple color #1783 flash different color on close
  • fix(receive): increase time to wait for LDK
  • fix(settings): ChannelList: always navigate to transfer flow
  • fix(ui): update prompt showing too often
  • fix(receive): add vibration on receive
  • chore: update husky prepare command

Linked Issues/Tasks

Closes #1783

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (improving code without creating new functionality)

Tests

  • Detox test
  • Unit test
  • No test

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@babel/compat-data@7.24.1 None 0 64.6 kB nicolo-ribaudo
npm/@babel/core@7.24.4 environment, filesystem, unsafe +3 902 kB nicolo-ribaudo
npm/@babel/generator@7.24.4 None +4 831 kB nicolo-ribaudo
npm/@babel/helper-annotate-as-pure@7.18.6 None 0 2.69 kB nicolo-ribaudo
npm/@babel/helper-create-class-features-plugin@7.24.1 None 0 430 kB nicolo-ribaudo
npm/@babel/helper-create-regexp-features-plugin@7.22.1 None +1 80.8 kB nicolo-ribaudo
npm/@babel/helper-function-name@7.21.0 None 0 21.4 kB nicolo-ribaudo
npm/@babel/helper-member-expression-to-functions@7.23.0 None 0 55 kB nicolo-ribaudo
npm/@babel/helper-module-imports@7.22.15 None 0 54.4 kB nicolo-ribaudo
npm/@babel/helper-module-transforms@7.23.3 None 0 158 kB nicolo-ribaudo
npm/@babel/helper-plugin-utils@7.21.5 None 0 11.9 kB nicolo-ribaudo
npm/@babel/helper-simple-access@7.22.5 None 0 14.1 kB nicolo-ribaudo
npm/@babel/helper-split-export-declaration@7.22.6 None 0 10.7 kB nicolo-ribaudo
npm/@babel/helper-validator-identifier@7.22.20 None 0 49.1 kB nicolo-ribaudo
npm/@babel/helpers@7.24.4 None 0 650 kB nicolo-ribaudo
npm/@babel/highlight@7.24.2 environment +1 26.1 kB nicolo-ribaudo
npm/@babel/parser@7.24.4 None 0 1.88 MB nicolo-ribaudo
npm/@babel/plugin-syntax-export-default-from@7.18.6 None 0 2.79 kB nicolo-ribaudo
npm/@babel/plugin-syntax-flow@7.21.4 None 0 5.42 kB nicolo-ribaudo
npm/@babel/plugin-syntax-jsx@7.21.4 None 0 4.13 kB nicolo-ribaudo
npm/@babel/plugin-syntax-typescript@7.21.4 None 0 6.86 kB nicolo-ribaudo
npm/@babel/plugin-transform-arrow-functions@7.24.1 None 0 5.55 kB nicolo-ribaudo
npm/@babel/plugin-transform-async-to-generator@7.24.1 None +3 97.4 kB nicolo-ribaudo
npm/@babel/plugin-transform-block-scoping@7.24.4 None 0 88.1 kB nicolo-ribaudo
npm/@babel/plugin-transform-classes@7.24.1 None +1 127 kB nicolo-ribaudo
npm/@babel/plugin-transform-computed-properties@7.24.1 None 0 22.7 kB nicolo-ribaudo
npm/@babel/plugin-transform-destructuring@7.24.1 None 0 81.9 kB nicolo-ribaudo
npm/@babel/plugin-transform-flow-strip-types@7.21.0 None 0 17.5 kB nicolo-ribaudo
npm/@babel/plugin-transform-function-name@7.24.1 None 0 6.2 kB nicolo-ribaudo
npm/@babel/plugin-transform-literals@7.24.1 None 0 4.63 kB nicolo-ribaudo
npm/@babel/plugin-transform-modules-commonjs@7.24.1 None 0 42.4 kB nicolo-ribaudo
npm/@babel/plugin-transform-named-capturing-groups-regex@7.22.5 None +1 58.7 kB nicolo-ribaudo
npm/@babel/plugin-transform-nullish-coalescing-operator@7.24.1 None 0 9.15 kB nicolo-ribaudo
npm/@babel/plugin-transform-optional-chaining@7.24.1 None 0 38 kB nicolo-ribaudo
npm/@babel/plugin-transform-parameters@7.24.1 None 0 64.9 kB nicolo-ribaudo
npm/@babel/plugin-transform-private-methods@7.24.1 None 0 4.69 kB nicolo-ribaudo
npm/@babel/plugin-transform-private-property-in-object@7.24.1 None +1 22.9 kB nicolo-ribaudo
npm/@babel/plugin-transform-shorthand-properties@7.24.1 None 0 7.11 kB nicolo-ribaudo
npm/@babel/plugin-transform-spread@7.24.1 None 0 21.2 kB nicolo-ribaudo
npm/@babel/plugin-transform-sticky-regex@7.24.1 None 0 4.64 kB nicolo-ribaudo
npm/@babel/plugin-transform-template-literals@7.24.1 None 0 15.9 kB nicolo-ribaudo
npm/@babel/plugin-transform-typescript@7.22.3 None 0 126 kB nicolo-ribaudo
npm/@babel/plugin-transform-unicode-regex@7.24.1 None +1 57.7 kB nicolo-ribaudo
npm/@babel/preset-env@7.24.4 environment, filesystem +58 2.46 MB nicolo-ribaudo
npm/@babel/runtime@7.24.4 None 0 262 kB nicolo-ribaudo
npm/@babel/traverse@7.24.1 None +1 655 kB nicolo-ribaudo
npm/@babel/types@7.24.0 environment +1 2.42 MB nicolo-ribaudo
npm/@commitlint/cli@19.2.2 Transitive: environment, filesystem, shell, unsafe +59 3.78 MB escapedcat
npm/@commitlint/config-conventional@19.2.2 Transitive: filesystem +7 97.7 kB escapedcat
npm/@hyperswarm/dht@6.5.1 None +6 179 kB mafintosh
npm/@jridgewell/gen-mapping@0.3.3 None 0 79.2 kB jridgewell
npm/@jridgewell/trace-mapping@0.3.18 None +2 259 kB jridgewell
npm/@noble/hashes@1.3.1 None 0 743 kB paulmillr
npm/@protobufjs/aspromise@1.1.2 None 0 9.05 kB dcode
npm/@ptsecurity/commitlint-config@2.0.0 None 0 3.5 kB ptsecurity
npm/@radar/lnrpc@0.11.1-beta.1 environment, filesystem Transitive: network +24 8.82 MB cavan-radar
npm/@react-native/babel-preset@0.73.21 environment Transitive: filesystem, unsafe +27 2.53 MB react-native-bot
npm/@react-native/eslint-config@0.73.2 Transitive: environment, filesystem, unsafe +30 7.39 MB react-native-bot
npm/@react-native/metro-config@0.73.5 environment Transitive: filesystem +4 1 MB react-native-bot
npm/@react-native/typescript-config@0.73.1 None 0 2.08 kB lunaleaps
npm/@synonymdev/slashtag@1.0.0-wip.2 None +13 429 kB nzh
npm/@synonymdev/slashtags-rpc@1.0.0-alpha.2 None +1 21.5 kB nzh
npm/@types/b4a@1.6.4 None 0 8.93 kB types
npm/@types/babel__traverse@7.20.0 None 0 165 kB types
npm/@types/bip21@2.0.3 None 0 3.16 kB types
npm/@types/istanbul-lib-coverage@2.0.4 None 0 5.76 kB types
npm/@types/jest@29.5.12 None +1 224 kB types
npm/@types/lodash@4.17.0 None 0 862 kB types
npm/@types/mime@3.0.4 None 0 3.25 kB types
npm/@types/node@20.3.2 None 0 3.79 MB types
npm/@types/react-native-dotenv@0.2.2 None 0 2.8 kB types
npm/@types/react@18.2.78 None +2 1.66 MB types
npm/@types/redux-logger@3.0.13 None 0 6.89 kB types
npm/@types/styled-components-react-native@5.2.5 None +4 1.65 MB types
npm/@types/url-parse@1.4.11 None 0 5.74 kB types
npm/@types/uuid@9.0.8 None 0 6.74 kB types
npm/@typescript-eslint/utils@5.62.0 Transitive: environment, filesystem +12 2.78 MB jameshenry
npm/ajv@8.12.0 eval Transitive: unsafe +3 1.52 MB esp
npm/b4a@1.6.3 None 0 27.5 kB kasperisager
npm/babel-plugin-polyfill-corejs2@0.4.10 Transitive: unsafe +3 328 kB nicolo-ribaudo
npm/bech32@2.0.0 None 0 10.2 kB junderw
npm/beignet@0.0.35 network +7 9.83 MB coreyphillips
npm/bip21@2.0.3 None +1 239 kB junderw
npm/bip32@4.0.0 None +1 74.4 kB junderw
npm/bip39@3.1.0 None 0 331 kB junderw
npm/bitcoin-address-validation@2.2.3 None +2 78.2 kB ruigomes
npm/bitcoin-json-rpc@1.3.3 Transitive: environment, network +4 5.64 MB abrkn
npm/bitcoin-units@0.3.0 None +1 113 kB ruigomes
npm/bitcoinjs-lib@6.1.5 None +2 338 kB junderw
npm/bs58check@3.0.1 None +2 20.8 kB junderw
npm/caniuse-lite@1.0.30001600 None 0 2 MB caniuse-lite
npm/compact-encoding-net@1.2.0 None 0 12.5 kB kasperisager
npm/compact-encoding@2.11.0 None 0 47.8 kB mafintosh
npm/core-js-compat@3.33.2 None 0 686 kB zloirock
npm/cross-fetch@3.1.8 network +1 125 kB lquixada
npm/debug@4.3.4 environment +1 49.2 kB qix
npm/detox@20.20.2 environment, eval, filesystem, network, shell, unsafe +48 13.7 MB wix.mobile
npm/dht-rpc@6.7.0 None +5 727 kB mafintosh
npm/electron-to-chromium@1.4.719 None 0 282 kB kilianvalkhof
npm/eslint-plugin-ft-flow@3.0.7 None +1 521 kB brianzchen
npm/eslint@8.57.0 environment, filesystem Transitive: unsafe +23 5.85 MB eslintbot
npm/fastestsmallesttextencoderdecoder-encodeinto@1.0.22 None 0 18.7 kB anonyco
npm/fetch-blob@3.2.0 None 0 21.8 kB endless
npm/flow-parser@0.206.0 None 0 768 kB flowtype
npm/follow-redirects@1.15.2 network 0 28.3 kB rubenverborgh
npm/fuzzysort@1.9.0 None 0 32.4 kB farzher
npm/glob@7.2.3 filesystem Transitive: environment +3 76.3 kB isaacs
npm/husky@9.0.11 environment, filesystem, shell 0 3.61 kB typicode
npm/hyperbee@2.8.0 None 0 83.4 kB mafintosh
npm/hypercore-crypto@3.3.1 None 0 9.87 kB mafintosh
npm/hyperdrive@11.0.0-alpha.11 None 0 21.6 kB mafintosh
npm/i18next-icu@2.3.0 None 0 712 kB adrai
npm/i18next@23.11.2 None 0 635 kB adrai
npm/ignore@5.2.4 None 0 51.2 kB kael
npm/immer@10.0.4 environment 0 623 kB mweststrate
npm/intl-messageformat@10.5.11 None +2 1.28 MB longlho
npm/jdenticon@3.2.0 None 0 707 kB dmester
npm/jest@29.7.0 None 0 5.01 kB simenb
npm/lnurl@0.24.2 filesystem, network 0 110 kB chill1
npm/lottie-react-native@6.7.2 None 0 292 kB matinzd
npm/metro-config@0.80.7 filesystem Transitive: environment +4 361 kB metro-bot
npm/metro-runtime@0.80.7 None 0 73.3 kB metro-bot
npm/minimist@1.2.8 None 0 54.5 kB ljharb
npm/nan@2.17.0 None 0 424 kB kkoopa
npm/nano-staged@0.8.0 Transitive: environment +1 46.8 kB usmanyunusov
npm/nanoid@3.3.6 None 0 21.7 kB ai
npm/node-fetch@2.6.11 network +1 212 kB node-fetch-bot
npm/noise-curve-ed@2.0.1 None +1 9.55 kB chm-diederichs
npm/noise-handshake@3.0.2 None +1 40 kB mafintosh
npm/pirates@4.0.5 unsafe 0 13.4 kB danez
npm/pretty-format@29.5.0 None 0 60.2 kB simenb
npm/protomux@3.4.1 None 0 30 kB mafintosh
npm/random-access-web-storage@2.0.0 None +1 27.3 kB nzh
npm/react-i18next@14.1.0 None 0 331 kB adrai
npm/react-native-address-generator@0.3.3 None 0 68.7 MB coreyphillips
npm/react-native-biometrics@3.0.1 None 0 169 kB jayfunk
npm/react-native-bundle-visualizer@3.1.3 Transitive: environment +9 161 kB ijzerenhein
npm/react-native-camera-kit@14.0.0-beta13 None 0 264 kB scarlac
npm/react-native-device-info@10.13.1 None 0 682 kB schie
npm/react-native-dotenv@3.4.11 environment, filesystem 0 22 kB goatandsheep
npm/react-native-draggable-flatlist@4.0.1 None 0 523 kB computerjazz
npm/react-native-exit-app@2.0.0 None 0 40.3 kB wumke
npm/react-native-fetch-api@3.0.0 None 0 40.9 kB acostalima
npm/react-native-flipper@0.212.0 None 0 120 kB flipper-bot
npm/react-native-fs@2.20.0 None 0 570 kB hagen
npm/react-native-gesture-handler@2.15.0 None +1 3.33 MB jakub.piasecki
npm/react-native-haptic-feedback@2.2.0 None 0 696 kB mkuczera
npm/react-native-image-picker@7.1.2 None 0 178 kB johandutoit
npm/react-native-keyboard-accessory@0.1.16 None 0 30.1 kB ardaogulcan
npm/react-native-keychain@8.2.0 None 0 205 kB oblador
npm/react-native-localize@3.0.2 None 0 125 kB zoontek
npm/react-native-mmkv-flipper-plugin@1.0.0 None 0 5.58 kB krosf
npm/react-native-mmkv@2.12.2 None 0 3.24 MB mrousavy
npm/react-native-modal@13.0.1 None 0 72.7 kB mmazzarolo
npm/react-native-polyfill-globals@3.1.0 network 0 19.9 kB acostalima
npm/react-native-qrcode-svg@6.3.0 None 0 144 kB awesomejerry
npm/react-native-quick-actions@0.3.13 None 0 532 kB jordanbyron
npm/react-native-quick-base64@2.1.1 None 0 2.11 MB craftzdog
npm/react-native-quick-crypto@0.6.1 None 0 821 kB mrousavy
npm/react-native-reanimated-carousel@3.5.1 None 0 595 kB zhaodonghao586
npm/react-native-reanimated@3.8.1 environment, eval +2 3.66 MB piaskowyk
npm/react-native-release-profiler@0.1.6 None 0 691 kB skapala
npm/react-native-restart@0.0.27 None 0 599 kB avishayil
npm/react-native-safe-area-context@4.9.0 environment 0 236 kB janicduplessis
npm/react-native-screens@3.30.1 None +1 1.28 MB tboba
npm/react-native-share@10.2.0 None 0 317 kB mateusandrade
npm/react-native-skia-stub@0.0.1 None 0 3.44 kB limpbrains
npm/react-native-svg-transformer@1.3.0 None 0 13.5 kB kristerkari
npm/react-native-svg@15.1.0 network 0 2.84 MB wolewicki
npm/react-native-tcp-socket@5.6.2 None 0 144 kB rapsssito
npm/react-native-toast-message@2.2.0 None 0 42 kB calintamas
npm/react-native-zip-archive@6.1.0 None 0 114 kB plrthink
npm/react-native@0.73.8 environment, network Transitive: filesystem +12 71.7 MB react-native-bot
npm/react-redux@9.1.1 environment 0 739 kB acemarke
npm/redux-flipper@2.0.3 None 0 10.6 kB plwai
npm/redux-logger@3.0.6 None 0 34.3 kB evgenyrodionov
npm/redux-thunk@3.1.0 None 0 26.8 kB acemarke
npm/redux@5.0.1 None 0 290 kB phryneas
npm/resolve@1.22.2 environment, filesystem 0 145 kB ljharb
npm/rn-android-keyboard-adjust@2.1.2 None 0 29.3 kB darleikroth
npm/rn-qr-generator@1.4.0 None 0 111 kB gevorg94
npm/safety-catch@1.0.2 None 0 2.77 kB mafintosh
npm/sodium-react-native-direct@0.4.2 None 0 13.4 MB pwltr
npm/sodium-universal@4.0.0 None +10 4.06 MB mafintosh
npm/stream-browserify@3.0.0 None 0 11.6 kB goto-bus-stop
npm/stream-json@1.8.0 None 0 90.8 kB elazutkin
npm/streamx@2.13.2 None +1 50.6 kB mafintosh
npm/styled-components@5.3.11 environment +2 3.03 MB probablyup
npm/timeout-refresh@2.0.1 None 0 7.9 kB mafintosh
npm/tslib@2.5.0 None 0 60 kB typescript-bot
npm/typeforce@1.18.0 None 0 19.1 kB dcousens
npm/typescript@5.4.5 None 0 32.4 MB typescript-bot
npm/url-parse@1.5.10 None +2 78.5 kB swaagie
npm/wif@2.0.6 None +3 27 kB dcousens
npm/yargs@17.7.2 environment, filesystem 0 292 kB oss-bot

🚮 Removed packages: npm/@nodelib/fs.stat@2.0.5, npm/@nodelib/fs.walk@1.2.8, npm/accepts@1.3.8, npm/ansi-regex@5.0.1, npm/async@3.2.4, npm/bn.js@4.12.0, npm/brorand@1.1.0, npm/browserify-aes@1.2.0, npm/buffer@5.7.1, npm/catering@2.1.1, npm/decode-uri-component@0.2.2, npm/diff-sequences@29.6.3, npm/domhandler@5.0.3, npm/entities@4.5.0, npm/escape-html@1.0.3, npm/esprima@4.0.1, npm/estraverse@5.3.0, npm/event-target-shim@5.0.1, npm/evp_bytestokey@1.0.3, npm/function.prototype.name@1.1.6, npm/get-caller-file@2.0.5, npm/has-bigints@1.0.2, npm/has-symbols@1.0.3, npm/has@1.0.3, npm/hash.js@1.1.7, npm/is-array-buffer@3.0.2, npm/is-callable@1.2.7, npm/is-core-module@2.13.1, npm/is-date-object@1.0.5, npm/is-docker@2.2.1, npm/is-string@1.0.7, npm/is-symbol@1.0.4, npm/is-typed-array@1.1.12, npm/is-wsl@2.2.0, npm/isarray@1.0.0, npm/istanbul-lib-coverage@3.2.0, npm/jest-environment-node@29.7.0, npm/merge2@1.4.1, npm/mime-db@1.52.0, npm/mime-types@2.1.35, npm/minimalistic-assert@1.0.1, npm/module-error@1.0.2, npm/neo-async@2.6.2, npm/node-gyp-build@4.6.0, npm/object-inspect@1.13.1, npm/parse-asn1@5.1.6, npm/picomatch@2.3.1, npm/prompts@2.4.2, npm/queue-microtask@1.2.3, npm/queue-tick@1.0.1, npm/regexp.prototype.flags@1.5.1, npm/serve-static@1.15.0, npm/set-function-name@2.0.1, npm/source-map@0.6.1, npm/type-check@0.4.0, npm/unpipe@1.0.0, npm/util-deprecate@1.0.2, npm/v8-to-istanbul@9.1.0, npm/walker@1.0.8

View full report↗︎

Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
Install scripts npm/protobufjs@7.2.4
  • Install script: postinstall
  • Source: node scripts/postinstall
Install scripts npm/protobufjs@6.11.3
  • Install script: postinstall
  • Source: node scripts/postinstall
Install scripts npm/tiny-secp256k1@1.1.6
  • Install script: install
  • Source: npm run build || echo "secp256k1 bindings compilation fail. Pure JS implementation will be used."
Install scripts npm/detox@20.20.2
  • Install script: postinstall
  • Source: node scripts/postinstall.js
Install scripts npm/sodium-react-native-direct@0.4.2
  • Install script: postinstall
  • Source: tar -xzf libsodium/build.tgz --directory ./libsodium

View full report↗︎

Next steps

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/protobufjs@7.2.4
  • @SocketSecurity ignore npm/protobufjs@6.11.3
  • @SocketSecurity ignore npm/tiny-secp256k1@1.1.6
  • @SocketSecurity ignore npm/detox@20.20.2
  • @SocketSecurity ignore npm/sodium-react-native-direct@0.4.2

@pwltr pwltr merged commit 13cc008 into master May 6, 2024
5 of 6 checks passed
@pwltr pwltr deleted the fix/various-fixes branch May 6, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Onchain receive sheet flashes purple color
2 participants