Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lightning): update transfer UI #1553

Merged
merged 1 commit into from
Feb 12, 2024
Merged

fix(lightning): update transfer UI #1553

merged 1 commit into from
Feb 12, 2024

Conversation

pwltr
Copy link
Collaborator

@pwltr pwltr commented Feb 12, 2024

Description

Updates the UI to better show transfers from and to spending, also contains most of the design updates from v46 related to transfers. I moved some state related to transfers to its own field in wallet.transfers, some of this is duplicated but this makes it more explicit and way easier to work with.

Linked Issues/Tasks

Add any links to GitHub issues or Asana tasks that are relevant to this pull request.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (improving code without creating new functionality)

Tests

  • Detox test
  • Unit test
  • No test

Screenshot / Video

channel open:

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-02-09.at.16.06.10.mp4

channel close:

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-02-09.at.16.00.27.mp4

@limpbrains
Copy link
Collaborator

Not sure if this needs to be fixed in this ticket, but:
After I've initiated transfer to savings on Transfer screen slider is still shows that I have a channel

image

@limpbrains
Copy link
Collaborator

Also this error appeared:

 ERROR  Error in setWalletData: [TypeError: Cannot read property 'height' of undefined]
 LOG  [TypeError: Cannot read property 'height' of undefined]

@limpbrains
Copy link
Collaborator

Not sure if this needs to be fixed in this ticket, but: After I've initiated transfer to savings on Transfer screen slider is still shows that I have a channel

Same happend when I've closed LN connection. After tx was confirmed and transfer was complete, I've opened Transfer flow and slider was not on the 0 position.

After app restart everything was correct

@pwltr
Copy link
Collaborator Author

pwltr commented Feb 12, 2024

After I've initiated transfer to savings on Transfer screen slider is still shows that I have a channel

I think that needs to be addressed in RN-LDK, see #1261

I'll try to fix the other findings

@pwltr pwltr force-pushed the fix/transfer-savings branch from 2c5404d to b134513 Compare February 12, 2024 13:09
@pwltr pwltr requested a review from limpbrains February 12, 2024 13:09
@limpbrains
Copy link
Collaborator

Can we fix this one ot it also requiers 1261 ?

Simulator.Screen.Recording.-.iPhone.15.-.2024-02-12.at.13.22.08.mp4

@JeanlChristophe JeanlChristophe added this to the v.1 milestone Feb 12, 2024
@pwltr pwltr force-pushed the fix/transfer-savings branch from b134513 to 56a6a0a Compare February 12, 2024 17:02
@pwltr
Copy link
Collaborator Author

pwltr commented Feb 12, 2024

Can we fix this one ot it also requiers 1261 ?

It should open the initial LN flow now instead of the transfer flow.

@pwltr pwltr force-pushed the fix/transfer-savings branch from 56a6a0a to af785a9 Compare February 12, 2024 19:14
@pwltr pwltr merged commit 688f864 into master Feb 12, 2024
5 checks passed
@pwltr pwltr deleted the fix/transfer-savings branch February 12, 2024 20:00
@JeanlChristophe
Copy link

tested: OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Channel closing UX [Bug]: Activity update [Bug]: In-flight HTLC
3 participants