Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: save receive tags on ReceiveDetails screen #1062

Merged
merged 1 commit into from
May 24, 2023
Merged

fix: save receive tags on ReceiveDetails screen #1062

merged 1 commit into from
May 24, 2023

Conversation

limpbrains
Copy link
Collaborator

Description

Save tags on ReceiveDetails screen

Linked Issues/Tasks

closes #957

Type of change

Bug fix

Tests

No test

Screenshot / Video

QA Notes

  • open receive screen
  • save address
  • tap specify invoice
  • add tag
  • close this bottomsheet without tapping show QR code
  • send money to the address
  • check transaction, make sure tag is in place

@limpbrains limpbrains requested a review from pwltr May 24, 2023 12:43
@limpbrains limpbrains marked this pull request as ready for review May 24, 2023 12:43
@limpbrains limpbrains merged commit d0d4dcc into master May 24, 2023
@limpbrains limpbrains deleted the receive-tags branch May 24, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pwltr pwltr pwltr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Tag for receiving address is only saved if you show qrcode again
2 participants
@limpbrains @pwltr