Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lightning): calculate blocktank limits #1030

Merged
merged 2 commits into from
May 8, 2023
Merged

fix(lightning): calculate blocktank limits #1030

merged 2 commits into from
May 8, 2023

Conversation

pwltr
Copy link
Collaborator

@pwltr pwltr commented May 8, 2023 •
edited
Loading

Description

This change helps the user avoid running into BT channel cap limits in the QuickSetup, CustomSetup & Transfer flows.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Tests

  • Detox test
  • Unit test
  • No test

Screenshot / Video

image

QA Notes

Try to buy a channel with max channel size in the various flows.

@pwltr pwltr requested a review from coreyphillips May 8, 2023 13:51
@pwltr pwltr merged commit a3ca5db into master May 8, 2023
@pwltr pwltr deleted the fix/channel-buy-limits branch May 8, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coreyphillips coreyphillips coreyphillips approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pwltr @coreyphillips