-
Notifications
You must be signed in to change notification settings - Fork 1
fix: migration when user has connection issues #381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
|
From my observation may still persist as the migration screen seems not to disappear (or maybe I should wait a little longer?). First the orange Bitkit intro screen displays for quite a long time, then the migration screen is triggered. It is displayed until the network comes back. Good thing is that it recovers and wallet is migrated successfully. Tested as follows:
Logs: Screen.Recording.2026-01-21.at.15.26.13-1.mov |
|
Posted also for bitkit-android: synonymdev/bitkit-android#697 |
|
@piotr-iohk in this case it seems internet is detected but is blocked (rather than being detected as not connected). I added a 2 minutes timeout so if the connection is bad/ unstable it will load for 2 minutes then loader will not show, and migration should still finish when user is connected again. Does 2 minutes makes sense? |
This comment has been minimized.
This comment has been minimized.
|
Repeated the test:
logs: It seems the loader did not disappear for me after 2 mins, but 4-5 mins... |
|
I'll check the timing, I think app not recovering on its own when network is back is something different though, since we don't have any auto restart of failed node when connection is back, so we can make a separate issue for this. |
This comment has been minimized.
This comment has been minimized.
|
Retested: Migration with normal network
Screen.Recording.2026-01-22.at.13.19.29.movMigration with 100% loss network
logs: Screen.Recording.2026-01-22.at.13.31.11.mov |
This comment has been minimized.
This comment has been minimized.
|
@piotr-iohk sorry I made a stupid mistake accidentally putting 120 nano seconds as the loader timeout instead of 120 seconds. I tested both scenarios and both worked now. |
Retested migration.
bitkit_logs_2026-01-22_14-28-59.zip Screen.Recording.2026-01-22.at.15.24.12.mov |
|
So the issue is that it does load the balance after network restart but after a long time, I fixed it and now it should load in a few seconds after node starts. I also added a warning toast on data out of sync while connecting. I think that should make this good enough. |
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
|
@pwltr @piotr-iohk @jvsena42 |
|
Tested, LGTM 🙏 Screen.Recording.2026-01-22.at.22.02.37.mov |
Fixes infinite load screen and adds retry when back online logic for migration when user has connection issues/ is offline