feat(ux): [product] rework oney popin#161
Merged
Jibbarth merged 2 commits intofeature/upgrade-v2from Apr 28, 2025
Merged
Conversation
Jibbarth
reviewed
Apr 28, 2025
| closeHandler() { | ||
| $("html") | ||
| .not(this.popinTarget) | ||
| .on("click", (e) => { |
Member
There was a problem hiding this comment.
Is there any "once" or something like this to avoid registering multiple event listener on html ?
Jibbarth
approved these changes
Apr 28, 2025
thomas-vermot-synolia
approved these changes
Apr 28, 2025
Jibbarth
force-pushed
the
feat/ux-product-oney-popin
branch
from
cef9cb7 to
f803cd1
Compare
Adding them to productMeta send them to controllers for check eligibility or popin content, whereas it's not needed
Jibbarth
force-pushed
the
feat/ux-product-oney-popin
branch
from
f803cd1 to
7887ace
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.