Skip to content

Remove Abstract Method Interface From Generator Constructor #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 8, 2022
Merged

Remove Abstract Method Interface From Generator Constructor #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ad434ea
Conditional Running
Behemyth Mar 6, 2022
a8765b4
Install Generator
Behemyth Mar 6, 2022
426b6f7
Download and Print
Behemyth Mar 6, 2022
49f99f5
Update data.py
Behemyth Mar 6, 2022
d578676
Add Download Print
Behemyth Mar 6, 2022
1001334
Early out construction
Behemyth Mar 6, 2022
e94c90f
Merge branch 'development' of https://github.com/Synodic-Software/CPP…
Behemyth Mar 6, 2022
7fd7824
Remove Abstract Requirement From Generator
Behemyth Mar 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 .github/workflows/release.yml → .github/workflows/python-publish.yml
View file
Open in desktop
File renamed without changes.
4 changes: 3 additions & 1 deletion cppython/plugins/generator/cmake.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,9 @@ class CMakeGenerator(Generator):
"""

def __init__(self, pyproject: PyProject, cmake_data: CMakeData) -> None:
super().__init__(pyproject, cmake_data)
"""
TODO
"""

@staticmethod
def name() -> str:
Expand Down
5 changes: 4 additions & 1 deletion cppython/project.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,10 @@ class Project(API):

def __init__(self, interface: Interface, pyproject: PyProject) -> None:

self.enabled = pyproject.cppython != None
self.enabled = pyproject.cppython is not None

if not self.enabled:
return

self._interface = interface

Expand Down
4 changes: 0 additions & 4 deletions cppython/schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,10 +145,6 @@ class Generator(Plugin, API):
Abstract type to be inherited by CPPython Generator plugins
"""

@abstractmethod
def __init__(self, pyproject: PyProject, generator_data: GeneratorData) -> None:
super().__init__()

@staticmethod
def plugin_group() -> str:
"""
Expand Down