Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support XDG_CONFIG_HOME to override config location #1011

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Conversation

synfinatic
Copy link
Owner

  • We still default to ~/.config/aws-sso
  • If you have set XDG_CONFIG_HOME, we will use that...
  • Unless you still have ~/.aws-sso, in which case we will use that

Fixes: #1003

@synfinatic synfinatic force-pushed the use-xdg-home branch 7 times, most recently from 197800c to a3957b8 Compare July 30, 2024 03:47
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.50%. Comparing base (11478d8) to head (e0d084b).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1011      +/-   ##
==========================================
- Coverage   84.61%   84.50%   -0.11%     
==========================================
  Files          34       34              
  Lines        3040     3019      -21     
==========================================
- Hits         2572     2551      -21     
  Misses        375      375              
  Partials       93       93              
Flag Coverage Δ
unittests 84.50% <100.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
internal/config/config.go 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11478d8...e0d084b. Read the comment docs.

@synfinatic synfinatic force-pushed the use-xdg-home branch 2 times, most recently from e0ed1d2 to 780a55a Compare July 30, 2024 03:59
- We still default to ~/.config/aws-sso
- If you have set XDG_CONFIG_HOME, we will use that...
- Unless you still have ~/.aws-sso, in which case we will use that

Fixes: #1003
@synfinatic synfinatic merged commit bb378be into main Jul 30, 2024
6 of 7 checks passed
@synfinatic synfinatic deleted the use-xdg-home branch July 30, 2024 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Honor $XDG_CONFIG_HOME
1 participant