Repository navigation
Stop the default folder: the pinning census undercounts - #858
Merged
Merged
Conversation
…0-05) Tony's per-ROI review of 20260629_312 (interface2, branch mlspike-blanking-rerun) called nine floor-pinned ROIs where the census flagged four, so the default folder keeps pinned events on ROIs 2, 3, 4, 17 and 18. 20260629_309 ROI 16 is over-cut, and _309, _316 and _235 have not been reviewed ROI by ROI. Tony ruled it a known contamination and the stop applies now. - current_export.toml: the senktide_ttx note declares it in the form refuse_if_contaminated reads, so dataset.default() refuses before the session confirmation. The steps_and_pins_excluded note's "nothing in this folder needs to change" is superseded in place, history kept. - tests/test_dataset.py: the default refuses through default(), and the note names what is contaminated and what clears it. - docs/todo: the record, the outcome-stated request to interface2 and a draft closing interface2#2 (20260707_346 checked absent from the folder itself), both for Tony to post (ADR-0007). - INDEX row on pinning corrected (the geometric test did run, 09-22) and extended; MILESTONES open table gains the stop. No exclusion is added here. What clears the stop is the producer's corrected export becoming the default. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
syncytium2
enabled auto-merge (squash)
October 5, 2026 13:35
syncytium2
added a commit
that referenced
this pull request
Oct 8, 2026
… the darkroom claim (#863) Written into docs/handoffs/ (nothing in flight): what waits on Tony (the contamination stop, two interface2 drafts, the open PRs and the two needing a call), what landed (#858-#862), the September rasters, and five traps from the day. The September raster darkroom claim is marked released. Co-authored-by: richard defazio <defazio@umich.edu> Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
syncytium2
pushed a commit
that referenced
this pull request
Oct 8, 2026
…c bench cannot Tony, once every tuned detector had landed within a few hundredths of F1 on fast: we need the revised bench with short intervals. The realistic bench's gaps were measured from peaks of a count in a 2 s window, so its shortest fast gap is 2.1 s. measure_close_events.py is a controlled test that needs no real recording: on the fast bench's recording half the gaps between planted events are set to one value, from 0.3 s to 10 s. At 10 s the detectors sit within 0.09 F1 of each other; at 1 s they span 0.40 to 0.66. The merge gap decides it, then the window: the shipped 3 s merge gaps lose a third of the events until the gap passes 5 s, and a 0.5 s window with a 0.2 s merge gap recalls every scored event down to 1 s. Under 1 s nothing separates the pair. A revised bench itself needs the real gaps measured again in a narrower window, and the default folder is stopped (#858). The record says what that waits on. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
syncytium2
pushed a commit
that referenced
this pull request
Oct 8, 2026
…ed at all The 2026-09-25 measurement counted co-activity in a 2 s window and merged events under 2 s apart, so the realistic bench holds no gap shorter than 2.1 s on fast. --window-sec sets the count's window, the window the floor is counted in and the merge distance together. The default is unchanged, floor key included, so the first measurement reproduces exactly. Nothing is measured in this commit: the default folder is stopped (#858). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tony's ruling, 2026-10-05, confirmed in the housekeeping session: the pinning undercount is a known contamination, and the stop applies now.
What changed: Tony reviewed every ROI of
20260629_312(interface2, branchmlspike-blanking-rerun). He called nine ROIs pinned to the floor; the census flagged four. So the default folder keeps pinned events on ROIs 2, 3, 4, 17 and 18.20260629_309ROI 16 is over-cut, and_309,_316and_235have not been reviewed ROI by ROI. All four recordings are DI.current_export.toml: thesenktide_ttx(default) note now declares the contamination in the formrefuse_if_contaminatedreads, sodataset.default()refuses. The refusal comes before the session confirmation, which makes the confirmation moot until the stop clears. Thesteps_and_pins_excludednote's "nothing in this folder needs to change" is superseded in place, with its history kept.tests/test_dataset.py: the default refuses throughdefault(), and the note names what is contaminated and what clears it. Delete this test in the change that makes the corrected export the default.20260707_346was checked absent against the folder itself.No exclusion is added in bugarach. What clears the stop is the producer's corrected export becoming the default.
🤖 Generated with Claude Code