-
Notifications
You must be signed in to change notification settings - Fork 43
FLUT-969263 - [Others] Improved UG API's #1281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: hotfix/hotfix-v30.1.37
Are you sure you want to change the base?
FLUT-969263 - [Others] Improved UG API's #1281
Conversation
Completed till trackball label format.
Build Status: INPROGRESS 🔃 |
CI Status: SUCCESS ✅ |
Build Status: INQUEUE 🕒 |
Build Status: INPROGRESS 🔃 |
CI Status: SUCCESS ✅ |
Build Status: INQUEUE 🕒 |
Build Status: INPROGRESS 🔃 |
CI Status: SUCCESS ✅ |
Build Status: INPROGRESS 🔃 |
CI Status: SUCCESS ✅ |
Build Status: INQUEUE 🕒 |
Build Status: INPROGRESS 🔃 |
CI Status: SUCCESS ✅ |
Build Status: INPROGRESS 🔃 |
CI Status: FAILURE ❌ |
Build Status: INPROGRESS 🔃 |
The CI Job is already running for this Pull Request/Merge Approved with latest commit id. You cannot trigger the duplicate job for same. |
CI Status: FAILURE ❌ |
Build Status: INPROGRESS 🔃 |
CI Status: SUCCESS ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Address all the review suggestions.
@@ -25,7 +25,7 @@ The customization of colors can be done for the following chart elements. | |||
|
|||
## Large fonts | |||
|
|||
The [`SfPyramidChart`](https://pub.dev/documentation/syncfusion_flutter_charts/latest/charts/SfPyramidChart-class.html) font size can be adjusted automatically based on device settings and the font size scaled based on the [`MediaQueryData.textScaleFactor`](https://api.flutter.dev/flutter/widgets/MediaQueryData/textScaleFactor.html). It also allows you to change the font size of all elements in Pyramid chart. | |||
The [`SfPyramidChart`](https://pub.dev/documentation/syncfusion_flutter_charts/latest/charts/SfPyramidChart-class.html) font size can be adjusted automatically based on device settings and the font size scaled based on the [`MediaQueryData.textScaleFactor`](https://api.flutter.dev/flutter/widgets/MediaQueryData/textScaler.html). It also allows you to change the font size of all elements in the Pyramid chart. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hyper link is updated but the hyperlink text is not updated. Use [MediaQueryData.textScaler
] instead of MediaQueryData.textScaleFactor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated with MediaQueryData.textScaler
@@ -11,7 +11,7 @@ documentation: ug | |||
|
|||
## Chart sizing | |||
|
|||
Chart renders based on the parent widget size. If you need the chart to be rendered in specific size, then set the size(width/height) to the parent widget. | |||
The chart renders based on the parent widget's size. If you need the chart to be rendered in a specific size, then set the size(width/height) to the parent widget. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use widget instead of widgets
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"widget's" is just possessive form of "widget", as per sentence formation widget's size give more readable than widget size.
@@ -32,7 +32,7 @@ Data label can be added to a chart series by enabling the [`isVisible`](https:// | |||
|
|||
|
|||
{% tabs %} | |||
{% highlight dart hl_lines="8" %} | |||
{% highlight dart hl_lines="21" %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why highlight line is changed in many places. Did you ensured the highlighted part is not changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The highlighted code line is mismatched. So updated proper code line number.
|
||
## Export image | ||
|
||
To export the pyramid chart as a PNG image, we can get the image by calling [`toImage`](https://api.flutter.dev/flutter/rendering/RenderRepaintBoundary/toImage.html) method in repaint boundary. | ||
To export the pyramid chart as a PNG image, you can get the image by calling [`toImage`](https://api.flutter.dev/flutter/rendering/RenderRepaintBoundary/toImage.html) method in repaint boundary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use we instead of you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Used we instead of you.
@@ -122,7 +122,7 @@ To export the pyramid chart as a PNG image, we can get the image by calling [`to | |||
|
|||
### Export PDF | |||
|
|||
Similar to the above way, we can also export the rendered Pyramid chart as a PDF document. We create the PDF document using PDF component. This can be done in the application level itself and please find the code snippet below. | |||
Similar to the above method, we can also export the rendered Pyramid chart as a PDF document. You create the PDF document using PDF component. This can be done at the application level itself. Please find the code snippet below. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use this:
Similar to the above way, we can also export the rendered Pyramid chart as a PDF document. We create the PDF document using PDF component. This can be done in the application level itself. Please find the code snippet below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated.
|
||
* [`color`](https://pub.dev/documentation/syncfusion_flutter_charts/latest/charts/DataLabelSettings/color.html) - used to change the background color of the data label shape. | ||
* [`color`](https://pub.dev/documentation/syncfusion_flutter_charts/latest/charts/DataLabelSettings/color.html) - used to change the color of the data label. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you checked this? The color property in data label is used set color for the data label shape.
Use the existing content.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensured, used existed content.
* [`textStyle`](https://pub.dev/documentation/syncfusion_flutter_charts/latest/charts/DataLabelSettings/textStyle.html) - used to change the data label text color, size, font family, font style, and font weight. | ||
* [`color`](https://pub.dev/documentation/syncfusion_flutter_charts/latest/charts/DataLabelSettings/color.html) - used to change the color of the data label. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why removed this? This is color inside a textstyle which applies color for the data label [data label text]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensured and updated.
Flutter/cartesian-charts/overview.md
Outdated
* [Integrating Syncfusion<sup>®</sup> flutter charts in a flutter web application](https://support.syncfusion.com/kb/article/9941/how-to-integrate-syncfusion-charts-in-flutter-web-application-sfcartesianchart). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the existing content.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Used existed content.
@@ -304,7 +306,7 @@ You can select a point or series programmatically on a chart using [`initialSele | |||
|
|||
## Toggle selection | |||
|
|||
You can decide, whether to deselect the selected data point/series or remain selected when interacted with it again by setting the [`toggleSelection`](https://pub.dev/documentation/syncfusion_flutter_charts/latest/charts/SelectionBehavior/toggleSelection.html) property `true` or `false`. If set to true, deselection will be performed else the point will not get deselected. | |||
You can decide, whether to deselect the selected data point/series or remain selected when interacted with again by setting the [`toggleSelection`](https://pub.dev/documentation/syncfusion_flutter_charts/latest/charts/SelectionBehavior/toggleSelection.html) property `true` or `false`. If set to true, deselection will be performed else the point will not get deselected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the existing content.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Used existed content.
@@ -9,7 +9,7 @@ documentation: ug | |||
|
|||
# Trendlines in Flutter Cartesian Charts (SfCartesianChart) | |||
|
|||
Trendlines are used to show the direction and speed of price. | |||
Trendlines are used to show the direction and speed of price movement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the existing content.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Used existed content.
Build Status: INQUEUE 🕒 |
Build Status: INPROGRESS 🔃 |
CI Status: SUCCESS ✅ |
Completed Cartesian Charts ensuring each public API in below mentioned pages and updated API links.
Overview
Getting Started
Chart Title
Chart Types
Multiple/Combo Charts
Series Customization
Axis Types
Axis Customization
Marker and Data label
Legend
Appearance
Annotations
Technical Indicators
Trendlines
Zooming and Panning
Trackball and Crosshair
Tooltip
Selection
Exporting
On-demand loading
Localization
Right to Left (RTL)
Accessibility
Public Methods
Callbacks
How to
Completed Funnel Chart ensuring each public API in below mentioned pages and updated API links.
Overview
Getting Started
Chart Title
Funnel Chart Features
Series Customization
Data label
Legend
Appearance
Tooltip
Selection
Exporting
Right to Left (RTL)
Accessibility
Public Methods
Callbacks
How to
Completed Pyramid Chart ensuring each public API in below mentioned pages and updated API links.
Overview
Getting Started
Chart Title
Pyramid Chart Features
Series Customization
Data label
Legend
Appearance
Tooltip
Selection
Exporting
Right to Left (RTL)
Accessibility
Public Methods
Callbacks
How to