Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rfq-indexer): add missing fields #3309

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

golangisfun123
Copy link
Collaborator

@golangisfun123 golangisfun123 commented Oct 17, 2024

Description
A clear and concise description of the features you're adding in this pull request.

Additional context
Add any other context about the problem you're solving.

Metadata

  • Fixes #[Link to Issue]

Summary by CodeRabbit

  • New Features
    • Enhanced data structure for bridge proof disputes with the addition of originChainId and originChain properties.
    • Improved event handling for various bridge-related events, ensuring consistent processing of fields like originChainId and amounts.

These changes contribute to more effective processing of bridge proof disputes and enhance the clarity and consistency of data handling across bridge events.

Copy link
Contributor

coderabbitai bot commented Oct 17, 2024

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

📥 Commits

Reviewing files that changed from the base of the PR and between 47a71b1 and 07c7118.

📒 Files selected for processing (3)
  • packages/rfq-indexer/indexer/abis/FastBridgeV2.ts (1 hunks)
  • packages/rfq-indexer/indexer/src/index.ts (1 hunks)
  • packages/rfq-indexer/indexer/src/utils/formatAmount.ts (1 hunks)
 ____________________________________________________________
< To infinity and beyond! Scouring your code for pesky bugs. >
 ------------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).

Walkthrough

The pull request introduces modifications to the BridgeProofDisputedEvents interface within the packages/rfq-indexer/api/src/types/index.ts file. Two new properties, originChainId (of type ColumnType<number>) and originChain (of type ColumnType<string>), have been added to the interface. This change enhances the data structure to include additional information pertinent to bridge proof disputes.

Changes

File Path Change Summary
packages/rfq-indexer/api/src/types/index.ts Updated BridgeProofDisputedEvents interface to include originChainId and originChain.

Possibly related PRs

  • RFQ-Indexer DB updates #3239: This PR modifies the BridgeProofDisputedEvents table schema, renaming fields to originChainId and originChain, which directly relates to the changes made in the main PR that adds these properties to the BridgeProofDisputedEvents interface.
  • Paro/rfq indexer updates suggs #3243: This PR mentions enhancing functionality related to dispute events, which aligns with the main PR's focus on adding properties to the BridgeProofDisputedEvents interface.
  • feat(rfq-indexer): add request column to BridgeRequested for refunds #3287: Although primarily focused on the BridgeRequested component, it also involves modifications to the BridgeRequestEvents interface, which may share context with the changes in the main PR regarding event handling and structure.

Suggested labels

size/xs, Sol, Typescript

Suggested reviewers

  • trajan0x
  • parodime
  • Defi-Moses

🐰 In the code where the bridges sway,
New fields hop in, brightening the day.
originChainId and originChain too,
Adding more data, oh what a view!
With every change, our structure grows,
In the world of types, the rabbit knows! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

cloudflare-workers-and-pages bot commented Oct 17, 2024

Deploying sanguine-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: 07c7118
Status: ✅  Deploy successful!
Preview URL: https://6c7c27d4.sanguine-fe.pages.dev
Branch Preview URL: https://fix-missing-fields.sanguine-fe.pages.dev

View logs

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.44834%. Comparing base (6b4c78e) to head (07c7118).
Report is 89 commits behind head on feat/explorer-w.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           feat/explorer-w       #3309   +/-   ##
===================================================
  Coverage         90.44834%   90.44834%           
===================================================
  Files                   54          54           
  Lines                 1026        1026           
  Branches                82          82           
===================================================
  Hits                   928         928           
  Misses                  95          95           
  Partials                 3           3           
Flag Coverage Δ
packages 90.44834% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Defi-Moses Defi-Moses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Base automatically changed from feat/explorer-w to master October 29, 2024 18:25
@golangisfun123 golangisfun123 changed the base branch from master to feat/explorer-w November 4, 2024 17:13
@github-actions github-actions bot added size/l and removed size/xs labels Nov 4, 2024
@abtestingalpha abtestingalpha merged commit 2341eac into feat/explorer-w Nov 4, 2024
35 checks passed
@abtestingalpha abtestingalpha deleted the fix-missing-fields branch November 4, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants