Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changing native token address standard [SLT-210] #3157

Merged
merged 4 commits into from
Sep 21, 2024

Conversation

Defi-Moses
Copy link
Collaborator

@Defi-Moses Defi-Moses commented Sep 19, 2024

Changes the native gas token address from 0x00... to 0xEe

Summary by CodeRabbit

  • New Features

    • Introduced a new constant for the native token address, enhancing clarity across multiple blockchain networks.
    • Added middleware for normalizing native token addresses in various routes, improving request handling.
  • Improvements

    • Updated token address references for various chains (Ethereum, Moonriver, Avalanche, etc.) to use the new native token address, improving accuracy in token assignments.
    • Adjusted test cases to reflect the new native token address, ensuring consistent testing outcomes.

Copy link
Contributor

coderabbitai bot commented Sep 19, 2024

Walkthrough

The changes involve the introduction of a new constant, NativeTokenAddress, in the bridgeable.ts file, which is assigned a specific Ethereum address. This constant replaces instances of ZeroAddress in the addresses property of several BridgeableToken exports, ensuring accurate token address assignments across multiple blockchain networks. Additionally, various test files were updated to utilize these constants instead of hardcoded values, enhancing the clarity and maintainability of the tests.

Changes

File Path Change Summary
packages/rest-api/src/constants/bridgeable.ts Added NativeTokenAddress constant; modified addresses for ETH, MOVR, AVAX, JEWEL, KLAY, MATIC, FTM to replace ZeroAddress with NativeTokenAddress.
packages/rest-api/src/tests/destinationTokensRoute.test.ts Updated fromToken parameter in tests to use constants instead of hardcoded addresses, including ZeroAddress.
packages/rest-api/src/tests/bridgeRoute.test.ts Modified token parameters in tests to utilize constants; added new test cases for ZeroAddress and NativeGasAddress.
packages/rest-api/src/tests/bridgeTxInfoRoute.test.ts Updated token addresses in tests to use constants instead of hardcoded values.
packages/rest-api/src/tests/swapRoute.test.ts Updated swap tests to use constants for token addresses; added tests for ZeroAddress and NativeGasAddress.
packages/rest-api/src/tests/swapTxInfoRoute.test.ts Replaced hardcoded token addresses with constants in multiple test cases.
packages/rest-api/src/middleware/normalizeNativeTokenAddress.ts Introduced normalizeNativeTokenAddress middleware to validate and normalize token addresses in requests.
packages/rest-api/src/routes/*.ts Added normalizeNativeTokenAddress middleware to various routes to process token address normalization.
packages/rest-api/src/utils/tokenAddressToToken.ts Simplified logic by removing checks for ZeroAddress and directly assigning chainData[tokenAddress].

Possibly related PRs

Suggested labels

size/m, M-deps

Suggested reviewers

  • Defi-Moses
  • bigboydiamonds
  • trajan0x
  • ChiTimesChi

In the meadow where tokens play,
A new address brightens the day.
No more placeholders, clear and true,
For bridges to cross, and dreams to pursue.
Hopping along, we celebrate this feat,
With every change, our code's more neat! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Defi-Moses Defi-Moses changed the title changing native token address standard changing native token address standard [SLT-210] Sep 19, 2024
Copy link

cloudflare-workers-and-pages bot commented Sep 19, 2024

Deploying sanguine-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: a415529
Status: ✅  Deploy successful!
Preview URL: https://93fb17aa.sanguine-fe.pages.dev
Branch Preview URL: https://feat-rest-api-native-token.sanguine-fe.pages.dev

View logs

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.95009%. Comparing base (49cf94d) to head (a415529).
Report is 12 commits behind head on master.

Additional details and impacted files
@@              Coverage Diff              @@
##              master       #3157   +/-   ##
=============================================
  Coverage   37.95009%   37.95009%           
=============================================
  Files            418         418           
  Lines          24245       24245           
  Branches          82          82           
=============================================
  Hits            9201        9201           
  Misses         14306       14306           
  Partials         738         738           
Flag Coverage Δ
packages 90.96267% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added size/s and removed size/xs labels Sep 20, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 1b9d204 and a415529.

Files selected for processing (12)
  • packages/rest-api/src/middleware/normalizeNativeTokenAddress.ts (1 hunks)
  • packages/rest-api/src/routes/bridgeRoute.ts (2 hunks)
  • packages/rest-api/src/routes/bridgeTxInfoRoute.ts (2 hunks)
  • packages/rest-api/src/routes/destinationTokensRoute.ts (2 hunks)
  • packages/rest-api/src/routes/swapRoute.ts (2 hunks)
  • packages/rest-api/src/routes/swapTxInfoRoute.ts (2 hunks)
  • packages/rest-api/src/tests/bridgeRoute.test.ts (4 hunks)
  • packages/rest-api/src/tests/bridgeTxInfoRoute.test.ts (4 hunks)
  • packages/rest-api/src/tests/destinationTokensRoute.test.ts (7 hunks)
  • packages/rest-api/src/tests/swapRoute.test.ts (6 hunks)
  • packages/rest-api/src/tests/swapTxInfoRoute.test.ts (7 hunks)
  • packages/rest-api/src/utils/tokenAddressToToken.ts (1 hunks)
Additional comments not posted (44)
packages/rest-api/src/middleware/normalizeNativeTokenAddress.ts (1)

6-18: LGTM!

The normalizeNativeTokenAddress middleware function is implemented correctly and follows the Express middleware pattern. It properly validates and normalizes the specified Ethereum addresses in the request query parameters using the ethers library functions. The replacement of the ZeroAddress with the NativeGasAddress is handled as per the project requirements.

The function is well-structured, readable, and should work as intended.

packages/rest-api/src/tests/swapTxInfoRoute.test.ts (7)

5-5: LGTM!

Importing constants for token addresses is a good practice to improve code maintainability and avoid hardcoded values.


14-15: LGTM!

Replacing hardcoded token addresses with constants is a good practice to improve code maintainability.


28-29: LGTM!

Replacing hardcoded token addresses with constants is a good practice to improve code maintainability.


43-44: LGTM!

Replacing hardcoded token addresses with constants is a good practice to improve code maintainability.


55-55: LGTM!

Replacing hardcoded token address with a constant is a good practice to improve code maintainability.


70-70: LGTM!

Replacing hardcoded token address with a constant is a good practice to improve code maintainability.


85-86: LGTM!

Replacing hardcoded token addresses with constants is a good practice to improve code maintainability.

packages/rest-api/src/tests/swapRoute.test.ts (8)

5-6: LGTM!

Importing constants from a centralized location is a good practice for maintainability. It makes the code more readable and easier to update in the future.


15-16: LGTM!

Replacing hardcoded token addresses with constants improves the maintainability of the test suite. It centralizes the token address definitions, making it easier to update them in the future.


26-52: LGTM!

The new test cases cover important scenarios involving ZeroAddress and NativeGasAddress. They ensure that the swap route returns a valid response for these scenarios, improving the overall test coverage.


57-58: LGTM!

Replacing hardcoded token addresses with constants improves the maintainability of the test suite. It centralizes the token address definitions, making it easier to update them in the future.


69-69: LGTM!

Replacing the hardcoded token address with a constant improves the maintainability of the test suite. It centralizes the token address definition, making it easier to update in the future.


84-84: LGTM!

Replacing the hardcoded token address with a constant improves the maintainability of the test suite. It centralizes the token address definition, making it easier to update in the future.


99-99: LGTM!

Replacing the hardcoded token address with a constant improves the maintainability of the test suite. It centralizes the token address definition, making it easier to update in the future.


100-100: LGTM!

Replacing the hardcoded token address with a constant improves the maintainability of the test suite. It centralizes the token address definition, making it easier to update in the future.

packages/rest-api/src/tests/bridgeTxInfoRoute.test.ts (4)

5-5: LGTM!

The import statement is correct and consistent with the list of alterations. Using constants for token addresses is a good practice to avoid hardcoding values in the test cases.


15-16: LGTM!

Replacing hardcoded token addresses with references to the USDC constant is a good practice. It makes the code more maintainable and less error-prone.


83-84: LGTM!

Replacing hardcoded token addresses with references to the USDC constant is a good practice. It makes the code more maintainable and less error-prone.


95-96: LGTM!

Replacing hardcoded token addresses with references to the USDC constant is a good practice. It makes the code more maintainable and less error-prone.

packages/rest-api/src/routes/destinationTokensRoute.ts (2)

11-11: LGTM!

The import statement for the normalizeNativeTokenAddress middleware is correctly structured and points to the right location.


102-102: Middleware added correctly.

The normalizeNativeTokenAddress middleware is correctly added to the route handler chain before the checksumAddresses middleware. It is invoked with the 'fromToken' parameter, indicating that it will process the fromToken query parameter.

This middleware ensures that the native token address in the fromToken query parameter is normalized to a consistent format before it is validated by the checksumAddresses middleware and further processed by the route handler.

packages/rest-api/src/tests/bridgeRoute.test.ts (5)

5-6: LGTM!

The imports are necessary for the new test cases and follow the correct syntax and path.


16-17: LGTM!

Using constants for token addresses is a good practice. The updated addresses correspond to the correct chains as per the test case description.


27-40: LGTM!

The new test case is well-structured and covers a previously untested scenario with ZeroAddress. The assertions are appropriate and cover the important aspects of the response.


42-57: LGTM!

The new test case is well-structured and covers a previously untested scenario with NativeGasAddress. The assertions are appropriate and cover the important aspects of the response.


119-120: LGTM!

Using constants for token addresses is a good practice. The updated addresses correspond to the correct chains as per the test case description.

packages/rest-api/src/tests/destinationTokensRoute.test.ts (9)

5-6: LGTM!

Importing constants for token addresses is a good practice. It improves code maintainability and readability.


15-15: LGTM!

Using a constant from USDC.addresses instead of hardcoding the token address is a good practice. It improves code maintainability and readability.


29-30: LGTM!

Using the NativeGasAddress constant instead of hardcoding the token address is a good practice. It improves code maintainability and readability.


32-38: LGTM!

Adding assertions to check the presence of symbol, address, and chainId properties in the response body is a good practice. It improves the test coverage and helps catch potential issues if the response format changes unexpectedly.


40-43: LGTM!

Adding a test case for the /destinationTokens endpoint with fromToken set to ZeroAddress is a good practice. It improves the test coverage and ensures the endpoint handles the ZeroAddress token correctly.


59-59: LGTM!

Using a constant from USDC.addresses instead of hardcoding the token address is a good practice. It improves code maintainability and readability.


73-73: LGTM!

Using a constant from USDT.addresses instead of hardcoding the token address is a good practice. Converting the address to lowercase tests the endpoint's handling of non-checksummed addresses, which improves the test coverage.


126-126: LGTM!

Using a constant from USDC.addresses instead of hardcoding the token address is a good practice. It improves code maintainability and readability.


138-138: LGTM!

Using a constant from USDC.addresses instead of hardcoding the token address is a good practice. It improves code maintainability and readability.

packages/rest-api/src/routes/swapRoute.ts (2)

10-10: LGTM!

The import statement for the normalizeNativeTokenAddress middleware is correctly added.


137-137: Verify the behavior of the normalizeNativeTokenAddress middleware.

The normalizeNativeTokenAddress middleware is correctly added to the route handler chain for the GET request at the root path ('/'), and it is applied before the checksumAddresses middleware.

The middleware is invoked with the expected parameters 'fromToken' and 'toToken', indicating that it will process these token address parameters in the request.

This change modifies the control flow of the route handling by adding an additional layer of processing for the specified token parameters before the checksum validation occurs.

To fully understand the impact of this change, please verify the behavior of the normalizeNativeTokenAddress middleware and ensure that it correctly normalizes the native token address as expected.

Run the following script to navigate to the middleware implementation and analyze its behavior:

Verification successful

Verification of normalizeNativeTokenAddress middleware behavior completed

The normalizeNativeTokenAddress middleware has been analyzed, and its behavior is consistent with the expected functionality:

  1. It correctly processes the 'fromToken' and 'toToken' parameters in the request query.
  2. The middleware normalizes valid Ethereum addresses to their checksum format.
  3. It handles the special case of native gas token by replacing the zero address with a specific native gas address constant.
  4. The implementation ensures proper chaining with other middlewares by calling next().

The addition of this middleware to the route handler chain enhances the robustness of token address handling in the API. It normalizes addresses before the checksum validation occurs, which is the correct order of operations.

This change positively impacts the route handling by ensuring consistent and correct representation of token addresses, especially for the native gas token.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Navigate to the `normalizeNativeTokenAddress` middleware implementation and analyze its behavior.

# Test: Find the middleware file. Expect: The file path to be found.
middleware_file=$(fd normalizeNativeTokenAddress.ts)
echo "Middleware file: $middleware_file"

# Test: Retrieve the middleware function implementation. Expect: The function to handle the native token address normalization.
cat $middleware_file | grep -A 10 -B 5 $'export function normalizeNativeTokenAddress'

Length of output: 423


Script:

#!/bin/bash
# Description: Analyze the content of the normalizeNativeTokenAddress middleware file

# Display the entire content of the middleware file
echo "=== Content of normalizeNativeTokenAddress.ts ==="
cat packages/rest-api/src/middleware/normalizeNativeTokenAddress.ts

# Search for functions related to normalizing addresses
echo -e "\n=== Functions related to normalizing addresses ==="
grep -n "function" packages/rest-api/src/middleware/normalizeNativeTokenAddress.ts

# Search for export statements
echo -e "\n=== Export statements ==="
grep -n "export" packages/rest-api/src/middleware/normalizeNativeTokenAddress.ts

Length of output: 1251

packages/rest-api/src/routes/swapTxInfoRoute.ts (2)

11-11: LGTM!

The import statement for the normalizeNativeTokenAddress middleware is correctly added.


119-119: Verify the correctness of the normalizeNativeTokenAddress middleware.

The normalizeNativeTokenAddress middleware is correctly added to the route handler for normalizing the fromToken and toToken query parameters before further processing.

To ensure the correctness of the native token address normalization, please verify the following:

  1. The normalizeNativeTokenAddress middleware correctly handles the new native token address 0xEe.
  2. The middleware replaces the old native token address 0x00... with the new address 0xEe when encountered in the specified query parameters.

You can use the following script to retrieve the middleware implementation and verify its logic:

packages/rest-api/src/routes/bridgeTxInfoRoute.ts (2)

11-11: LGTM!

The import statement for the normalizeNativeTokenAddress middleware is correctly added, following the existing conventions.


127-127: Middleware addition looks good!

The normalizeNativeTokenAddress middleware is correctly added to the route handler chain, targeting the fromToken and toToken query parameters. Its placement before the checksumAddresses middleware ensures that the token addresses are normalized prior to the checksum validation.

This addition aligns with the PR objective of updating the native token address standard. It modifies the request handling flow to normalize the token addresses before further processing, ensuring consistency with the new standard.

packages/rest-api/src/routes/bridgeRoute.ts (2)

10-10: LGTM!

The import statement for the normalizeNativeTokenAddress middleware is syntactically correct and follows the common practice of importing middleware functions in Express.js.


191-191: Verify the implementation of the normalizeNativeTokenAddress middleware.

The usage of the normalizeNativeTokenAddress middleware in the route handler is correct. It is applied to the fromToken and toToken parameters before the checksumAddresses middleware, suggesting that the normalization of native token addresses needs to happen before the checksum validation.

However, it is important to review the implementation of the normalizeNativeTokenAddress middleware to ensure that it correctly normalizes the native token addresses and handles any edge cases or potential errors.

To verify the implementation, navigate to the normalizeNativeTokenAddress middleware file and review the logic:

Verification successful

The normalizeNativeTokenAddress middleware implementation is correct and robust.

The middleware successfully normalizes native token addresses for the specified fields. It handles the following key aspects:

  • Processes multiple address fields as specified in the addressFields array.
  • Validates input as Ethereum addresses and converts them to checksum format.
  • Replaces the zero address with a native gas address (likely representing the native token, e.g., ETH).
  • Properly handles edge cases by checking for valid addresses and string types.

The implementation aligns with the expected behavior and should work as intended in the route handler.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the implementation of the `normalizeNativeTokenAddress` middleware.

# Test: Search for the middleware file. Expect: The file to exist.
fd normalizeNativeTokenAddress.ts ./packages/rest-api/src/middleware

# Test: Search for the middleware function. Expect: The function to be exported.
rg --type typescript $'export\s+(const|function)\s+normalizeNativeTokenAddress' ./packages/rest-api/src/middleware/normalizeNativeTokenAddress.ts

# Test: Search for the middleware logic. Expect: The logic to handle normalization and edge cases.
rg --type typescript --multiline $'(req|res|next)' ./packages/rest-api/src/middleware/normalizeNativeTokenAddress.ts

Length of output: 471


Script:

#!/bin/bash
# Description: Display the contents of the normalizeNativeTokenAddress middleware and search for its implementation

# Display the entire content of the file
cat ./packages/rest-api/src/middleware/normalizeNativeTokenAddress.ts

# Search for the exported function
grep -E "export (const|function) normalizeNativeTokenAddress" ./packages/rest-api/src/middleware/normalizeNativeTokenAddress.ts

# Search for the middleware logic
grep -E "(req|res|next)" ./packages/rest-api/src/middleware/normalizeNativeTokenAddress.ts

Length of output: 1644

@Defi-Moses Defi-Moses merged commit 1eb52a0 into master Sep 21, 2024
36 checks passed
@Defi-Moses Defi-Moses deleted the feat/rest-api-native-token branch September 21, 2024 10:49
abtestingalpha added a commit that referenced this pull request Sep 26, 2024
* update bl

* remove global solidity extension settings

* use monorepo support in global workspace only

* - use Solidity extension for formatting *.sol files
- use `forge fmt` as formatter in Solidity extension

* REST API Improvements [SLT-179] (#3133)

* fix swaptxinfo function

* Updates test coverage command

* migrating to using token addresses instead of symbols

* fix linting errors

* fixing swaptxinfocontroller

* new tests and new functionality

---------

Co-authored-by: abtestingalpha <abtestingalpha@gmail.com>

* Publish

 - @synapsecns/rest-api@1.0.75
 - @synapsecns/synapse-interface@0.38.4

* fix harmony proxy (#3149)


Co-authored-by: Trajan0x <trajan0x@users.noreply.github.com>

* merging rfq indexer into monorepo [SLT-164]  [SLT-176] (#3136)

* merging rfq indexer into monorepo

* nuke .env

* fix commands

* fix package name

* test coverage script

* rough pass at docs and some linting and fixes yarn

* Upgrades wagmi & rainbowkit

* indxer

* Adds invisible but used packages

* +recent-invalid-fills [SLT-188]

* Moves wagmi to root

* new endpoints and clean up linting

---------

Co-authored-by: Trajan0x <trajan0x@users.noreply.github.com>
Co-authored-by: abtestingalpha <abtestingalpha@gmail.com>
Co-authored-by: parodime <jordan@protochainresearch.com>

* Publish

 - @synapsecns/synapse-interface@0.38.5
 - @synapsecns/rfq-indexer-api@1.0.2
 - @synapsecns/rfq-indexer@0.0.2

* Adds /destinationTokens route [SLT-204] (#3151)

* Adds /destinationTokens route
* ZeroAddress & NativeGasAddress
* Adds test for native gas tokens
* Checksums incoming token address params

* Publish

 - @synapsecns/rest-api@1.0.76

* boba pause (#3150)

* boba pause

* only boba to txns

* Publish

 - @synapsecns/synapse-interface@0.38.6

* fix(synapse-interface): Reorders validation to check existence first (#3156)

* Reorders validation to check existence first
* Removes duplicates

* Publish

 - @synapsecns/rest-api@1.0.77

* Fix boba pause (#3158)

* Publish

 - @synapsecns/synapse-interface@0.38.7

* update bl

* feat(rest-api): Adds Swagger for api docs [SLT-205] (#3159)

* Adds Swagger for api docs

* Replace prepended verb Get routes with nouns

* Adds dev flag for swagger serverUrl

* Publish

 - @synapsecns/rest-api@1.1.0
 - @synapsecns/synapse-interface@0.38.8
 - @synapsecns/rfq-indexer-api@1.0.3
 - @synapsecns/rfq-indexer@0.0.3

* Pulls version from package json (#3160)

* Publish

 - @synapsecns/rest-api@1.1.1

* Require vs import due to file location (#3161)

* Require vs import due to file location

* Publish

 - @synapsecns/rest-api@1.1.2

* Prevent caching of api docs (#3162)

* Publish

 - @synapsecns/rest-api@1.1.3

* feat(contracts-rfq): relay/prove/claim with different address [SLT-130] (#3138)

* init. solidity ^. FbV2 relay/prove/claim overloads

* +IFastBridgeV2, explicit address0 cast, func scope & inheritdoc fixes

* pragma lock, contract relabel

* feat: start scoping V2 tests

* test: override relayer role scenarios, no longer enforced by V2

* test: finish the parity test

* test: the management methods

* test: dst chain scenarios

* test: bridge

* test: prove

* test: claim

* test: dispute

* test: refund

* test: bridge reverts

* remove redundant extend. rearrange inherit list

* revert 0.8.20 in favor of user (non-ws) setting

---------

Co-authored-by: ChiTimesChi <88190723+ChiTimesChi@users.noreply.github.com>

* Publish

 - FastBridge@0.4.0

* fix(promexporter): make spans better (#3164)

* move the errors

* [goreleaser]

* fix v to w

* changing native token address standard [SLT-210] (#3157)

* changing native token address standard

* fixing tests

* normalizeNativeTokenAddress middleware, additional tests

---------

Co-authored-by: abtestingalpha <abtestingalpha@gmail.com>

* Publish

 - @synapsecns/rest-api@1.1.4

* Refactoring rfq-indexer API and adding swagger docs [SLT-228] (#3167)

* refactoring and adding swagger

* remove testing scripts

* fix typos and consistency with 404 errors

* Publish

 - @synapsecns/rfq-indexer-api@1.0.4

* fix read mes (#3168)

* Publish

 - @synapsecns/contracts-core@1.0.32
 - FastBridge@0.4.1
 - @synapsecns/solidity-devops@0.4.5

* fix(opbot): use submitter get tx status [SLT-158] (#3134)

* use experimental logger to debug

* fix lint

* [goreleaser]

* use submitter instead of client

* [goreleaser]

* [goreleaser]

* fix(synapse-interface): Additional checks on screen [SLT-166] (#3152)

* Additional checks on screen

* Adds checks on chain/token changes

* Publish

 - @synapsecns/synapse-interface@0.38.9

* feat(synapse-interface): confirm new price [SLT-150]  (#3084)

* add bridge quote history middleware

* request user confirm changes when quoted price updates

* add conditions for displaying confirm change state

* track initial quote initializing confirm change state

* specify output delta threshold

* callback functions to handle initialize/accept/reset confirm changes flow

* quote countdown timer animation to signal refresh

* implement automatic refresh intervals

* mouse move to refresh automatic intervals

* add i8n translations for button text

---------

Co-authored-by: abtestingalpha <abtestingalpha@gmail.com>

* Publish

 - @synapsecns/synapse-interface@0.39.0

* fix: formatted bridge fee amount (#3165)

* Publish

 - @synapsecns/rest-api@1.1.5

* fix(contracts-rfq): CI workflows [SLT-245] (#3178)

* fix: license, files

* fix: package name

* build: update solhint to latest

* build: remove prettier dependencies

* fix: solhint workflows

* build: update solhint in other packages as well

* chore: solhint rules, exceptions

* fix: silence linter warnings in tests

* chore: forge fmt

* add variable to test linter CI

* Revert "add variable to test linter CI"

This reverts commit 0629309.

* Publish

 - @synapsecns/contracts-core@1.0.33
 - @synapsecns/contracts-rfq@0.5.0
 - @synapsecns/solidity-devops@0.4.6

* feat(api): bridge limits [SLT-165]  (#3179)

* adds `/bridgeLimits` route, controller

* fetch best sdk quote for min/max origin amounts

* add tests

* implement middleware to normalize addresses

* adds swagger doc

* Publish

 - @synapsecns/rest-api@1.2.0

* fix(contracts-rfq): limit the amount of solhint warnings [SLT-245] (#3182)

* ci: limit the amount of solhint warnings

* refactor: move the errors into the separate interface

* refactor: errors imports in tests

* Publish

 - @synapsecns/contracts-rfq@0.5.1

* ci: Solidity gas diff [SLT-259] (#3181)

* ci: run tests w/o coverage first for better visibility

* test: malform the test to check the adjusted workflow

* Revert "test: malform the test to check the adjusted workflow"

This reverts commit e7db6e1.

* ci: add gas-diff workflow

* try changing the contract to trigger gas diffs

* retrigger the workflow

* ci: provide the correct report path

* ci: run on pull requests only

* ci: save gas reports in monorepo root

* Revert "ci: run on pull requests only"

This reverts commit 0a01d60.

* Revert "try changing the contract to trigger gas diffs"

This reverts commit 91bc03e.

* refactor: wrap if statement

* refactor: exclude `solidity-devops` package in a more generic way

* ci: run tests w/o coverage for `solidity-devops`, add comments

* add generic comment to trigger `solidity-devops` workflows

* Revert "add generic comment to trigger `solidity-devops` workflows"

This reverts commit cc35a43.

* Publish

 - @synapsecns/contracts-rfq@0.5.2

* fix(contracts-core): set very high gas limit for intensive tests [SLT-259] (#3186)

* fix: set very high gas limit for intensive tests

* ci: speed up solidity coverage

* Publish

 - @synapsecns/contracts-core@1.0.34

* feat(rest-api): Adds validateRouteExists validation [SLT-260] (#3180)

* Adds validateRouteExists validation

* Remove timeouts for 400s

* Publish

 - @synapsecns/rest-api@1.3.0

* add duplicate command warning (#3174)

Co-authored-by: Trajan0x <trajan0x@users.noreply.github.com>

* reduce solhint warnings on FbV2 (#3189)

* reduce solhint warnings on FbV2

* fix whitespace

* Publish

 - @synapsecns/contracts-rfq@0.5.3

* ci: solidity gas diff options [SLT-267] (#3193)

* ci: ignore test files in gas diff report

* add some changes to the test files

* ci: define some options for gas-diff

* try changing the contract to trigger gas diffs

* Revert "try changing the contract to trigger gas diffs"

This reverts commit 4504e3c.

* Revert "add some changes to the test files"

This reverts commit 7e7d6cb.

* prove w/ tx id [SLT-181] (#3169)

* prove w/ tx id SLT-181

* +proveOther tests, forge fmt

* fmt

* fmt

* Publish

 - @synapsecns/contracts-rfq@0.5.4

* fix(sdk-router): disable ARB airdrop tests (#3195)

* Publish

 - @synapsecns/rest-api@1.3.1
 - @synapsecns/sdk-router@0.11.2
 - @synapsecns/synapse-interface@0.39.1
 - @synapsecns/widget@0.7.2

* Fixing issue for wallet integration [SLT-270] (#3194)

* slight modification to graphql call

* fixing explorer frontend as well

* Publish

 - @synapsecns/explorer-ui@0.3.3
 - @synapsecns/rest-api@1.3.2

* store relayer on relay [SLT-182] (#3170)

* store relayer on relay [SLT-182]

* +tests, zeroAddr check, fmt

* Publish

 - @synapsecns/contracts-rfq@0.5.5

* Adjust text to trigger build (#3199)

* Publish

 - @synapsecns/synapse-interface@0.39.2

* feat(synapse-interface): refund RFQ transaction [SLT-272] (#3197)

* Txn transaction refund tracking

* Update store to support tracking

* Query FastBridge contract for `bridgeStatuses` to find refund status

* Track bridge transaction `bridgeQuote.routerAddress` in store

* Fetch FastBridge contract address when only provided router address

* add translations

---------

Co-authored-by: aureliusbtc <82057759+aureliusbtc@users.noreply.github.com>
Co-authored-by: ChiTimesChi <88190723+ChiTimesChi@users.noreply.github.com>
Co-authored-by: abtestingalpha <abtestingalpha@gmail.com>
Co-authored-by: Defi-Moses <Defi-Moses@users.noreply.github.com>
Co-authored-by: trajan0x <83933037+trajan0x@users.noreply.github.com>
Co-authored-by: Trajan0x <trajan0x@users.noreply.github.com>
Co-authored-by: parodime <jordan@protochainresearch.com>
Co-authored-by: abtestingalpha <104046418+abtestingalpha@users.noreply.github.com>
Co-authored-by: abtestingalpha <abtestingalpha@users.noreply.github.com>
Co-authored-by: parodime <parodime@users.noreply.github.com>
Co-authored-by: vro <168573323+golangisfun123@users.noreply.github.com>
Co-authored-by: ChiTimesChi <ChiTimesChi@users.noreply.github.com>
Co-authored-by: bigboydiamonds <57741810+bigboydiamonds@users.noreply.github.com>
Co-authored-by: bigboydiamonds <bigboydiamonds@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants