go work sync fix #1980
go work sync fix #1980
Conversation
trajan0x
requested review from
dwasse,
aureliusbtc and
ChiTimesChi
as code owners
|
Important Auto Review SkippedReview was skipped due to path filters Files ignored due to path filters (2)
WalkthroughThe recent updates encompass a variety of enhancements across the project, including workflow optimization for Go, linting improvements, the introduction of new equipment fields in the game's data model, the addition of a conditional test for RFQ services, and a code quality directive in the quoter logic. These changes aim to refine development practices, expand game functionality, and ensure robust testing, all while maintaining code readability and performance. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1980 +/- ##
============================================
Coverage ? 41.67902%
============================================
Files ? 157
Lines ? 12138
Branches ? 0
============================================
Hits ? 5059
Misses ? 6475
Partials ? 604 ☔ View full report in Codecov by Sentry. |
github-actions
bot
added
go
trajan0x
force-pushed
the
fix/go-work-sync
branch
from
20754ed to
b21053f
Compare
Qodana for GoIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files ignored due to path filters (37)
agents/go.modis excluded by:!**/*.modagents/go.sumis excluded by:!**/*.sumcontrib/promexporter/go.modis excluded by:!**/*.modcontrib/promexporter/go.sumis excluded by:!**/*.sumcontrib/release-copier-action/go.modis excluded by:!**/*.modcontrib/release-copier-action/go.sumis excluded by:!**/*.sumcontrib/screener-api/go.modis excluded by:!**/*.modcontrib/screener-api/go.sumis excluded by:!**/*.sumcontrib/terraform-provider-helmproxy/go.modis excluded by:!**/*.modcontrib/terraform-provider-helmproxy/go.sumis excluded by:!**/*.sumcontrib/terraform-provider-iap/go.modis excluded by:!**/*.modcontrib/terraform-provider-iap/go.sumis excluded by:!**/*.sumcontrib/terraform-provider-kubeproxy/go.modis excluded by:!**/*.modcontrib/terraform-provider-kubeproxy/go.sumis excluded by:!**/*.sumcontrib/tfcore/go.modis excluded by:!**/*.modcontrib/tfcore/go.sumis excluded by:!**/*.sumcore/go.modis excluded by:!**/*.modcore/go.sumis excluded by:!**/*.sumethergo/go.modis excluded by:!**/*.modethergo/go.sumis excluded by:!**/*.sumgo.work.sumis excluded by:!**/*.sumservices/cctp-relayer/go.modis excluded by:!**/*.modservices/cctp-relayer/go.sumis excluded by:!**/*.sumservices/explorer/go.modis excluded by:!**/*.modservices/explorer/go.sumis excluded by:!**/*.sumservices/omnirpc/go.modis excluded by:!**/*.modservices/omnirpc/go.sumis excluded by:!**/*.sumservices/rfq/go.modis excluded by:!**/*.modservices/rfq/go.sumis excluded by:!**/*.sumservices/scribe/go.modis excluded by:!**/*.modservices/scribe/go.sumis excluded by:!**/*.sumservices/sinner/go.modis excluded by:!**/*.modservices/sinner/go.sumis excluded by:!**/*.sumservices/stiprelayer/go.modis excluded by:!**/*.modservices/stiprelayer/go.sumis excluded by:!**/*.sumtools/go.modis excluded by:!**/*.modtools/go.sumis excluded by:!**/*.sum
Files selected for processing (7)
- .github/workflows/go.yml (1 hunks)
- .github/workflows/scan.yml (3 hunks)
- .golangci.yml (1 hunks)
- README.md (1 hunks)
- contrib/promexporter/internal/gql/dfk/models.gen.go (1 hunks)
- services/rfq/e2e/rfq_test.go (1 hunks)
- services/rfq/relayer/quoter/quoter.go (1 hunks)
Files skipped from review as they are similar to previous changes (5)
- .github/workflows/go.yml
- .golangci.yml
- contrib/promexporter/internal/gql/dfk/models.gen.go
- services/rfq/e2e/rfq_test.go
- services/rfq/relayer/quoter/quoter.go
Additional comments: 3
.github/workflows/scan.yml (2)
- 1-1: Rename workflow from "SonarCloud" to "Code Scan" is clear and aligns with the added scanning capabilities.
- 28-31: Adding "Qodana Scan" step is appropriate for enhancing code quality checks. Ensure
QODANA_TOKENis securely stored in GitHub Secrets.README.md (1)
- 14-14: Adding the Codacy Badge to the README.md file is a good practice for showcasing code quality metrics.
| # permissions: | ||
| # contents: write | ||
| # pull-requests: write | ||
| # checks: write |
There was a problem hiding this comment.
Permissions are commented out. If these permissions are necessary for the workflow, they should be uncommented and properly configured.
-# permissions:
-# contents: write
-# pull-requests: write
-# checks: write
+ permissions:
+ contents: write
+ pull-requests: write
+ checks: writeCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| # permissions: | |
| # contents: write | |
| # pull-requests: write | |
| # checks: write | |
| permissions: | |
| contents: write | |
| pull-requests: write | |
| checks: write |
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to path filters (1)
qodana.yamlis excluded by:!**/*.yaml
Files selected for processing (2)
- .codeclimate.yml (1 hunks)
- .github/workflows/scan.yml (3 hunks)
Files skipped from review due to trivial changes (1)
- .codeclimate.yml
Files skipped from review as they are similar to previous changes (1)
- .github/workflows/scan.yml
Description
Fixes go work sync (golang/go#65363) by manually replacing references to the broken dependency
Summary by CodeRabbit
New Features
Tests
Chores