upgrade google terraform provider #1978
Conversation
|
Important Auto Review SkippedReview was skipped due to path filters Files ignored due to path filters (26)
WalkthroughThe overall change across various Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 2
Configuration used: CodeRabbit UI
Files ignored due to path filters (17)
agents/go.modis excluded by:!**/*.modagents/go.sumis excluded by:!**/*.sumcontrib/git-changes-action/go.modis excluded by:!**/*.modcontrib/git-changes-action/go.sumis excluded by:!**/*.sumcontrib/promexporter/go.modis excluded by:!**/*.modcontrib/promexporter/go.sumis excluded by:!**/*.sumcontrib/release-copier-action/go.modis excluded by:!**/*.modcontrib/release-copier-action/go.sumis excluded by:!**/*.sumcontrib/screener-api/go.modis excluded by:!**/*.modcontrib/screener-api/go.sumis excluded by:!**/*.sumcontrib/tfcore/generated/google/doc.gois excluded by:!**/generated/**contrib/tfcore/generated/google/generate.gois excluded by:!**/generated/**contrib/tfcore/generated/google/getters.gois excluded by:!**/generated/**contrib/tfcore/generated/google/google_gen.gois excluded by:!**/generated/**contrib/tfcore/go.modis excluded by:!**/*.modcontrib/tfcore/go.sumis excluded by:!**/*.sumgo.work.sumis excluded by:!**/*.sum
Files selected for processing (8)
- contrib/terraform-provider-helmproxy/provider/provider.go (2 hunks)
- contrib/terraform-provider-iap/provider/iap-tunnel.go (3 hunks)
- contrib/terraform-provider-iap/provider/keep_alive.go (3 hunks)
- contrib/terraform-provider-iap/provider/provider.go (1 hunks)
- contrib/terraform-provider-kubeproxy/provider/main_provider.go (2 hunks)
- contrib/terraform-provider-kubeproxy/provider/manifest_provider.go (2 hunks)
- contrib/tfcore/utils/tunnel.go (3 hunks)
- contrib/tfcore/utils/utils.go (1 hunks)
Additional comments: 6
contrib/terraform-provider-iap/provider/provider.go (1)
- 6-6: Ensure the updated import path
github.com/hashicorp/terraform-provider-google/google/provideris correct and compatible with the rest of the codebase.contrib/terraform-provider-helmproxy/provider/provider.go (1)
- 18-18: Confirm that the replacement of
google.Configwithtransport.Configis correctly implemented and compatible with the provider's configuration logic.contrib/terraform-provider-kubeproxy/provider/main_provider.go (1)
- 16-16: Ensure that the transition to
transport.Configfromgoogle.Configis correctly handled and does not affect the provider's functionality adversely.contrib/tfcore/utils/tunnel.go (1)
- 18-18: Confirm that the change of the
configparameter type to*transport.Configin theStartTunnelfunction is correctly implemented and integrated.contrib/terraform-provider-iap/provider/iap-tunnel.go (1)
- 89-89: Ensure that the switch to
transport.Configand the use ofutils.GetTokenSourcefor token source assignment indataSourceProxyfunction are correctly implemented.contrib/terraform-provider-kubeproxy/provider/manifest_provider.go (1)
- 195-195: Confirm that the type assertion to
*transport.Configin thegoogConfigureContextFuncfunction is correctly implemented and does not introduce any compatibility issues.
| func GetTokenSource(config *transport.Config) oauth2.TokenSource { | ||
| cfgReflection := reflect.ValueOf(config) | ||
| accessToken := GetUnexportedField(cfgReflection.FieldByName("tokenSource")).(oauth2.TokenSource) | ||
| return accessToken | ||
| } | ||
|
|
||
| func GetUnexportedField(field reflect.Value) interface{} { | ||
| return reflect.NewAt(field.Type(), unsafe.Pointer(field.UnsafeAddr())).Elem().Interface() | ||
| } |
There was a problem hiding this comment.
Using reflection and the unsafe package to access unexported fields can lead to maintenance challenges and potential runtime issues. Confirm the necessity of these approaches and ensure their safe use.
| cfgReflection := reflect.ValueOf(config) | ||
| context := utils.GetUnexportedField(cfgReflection.FieldByName("context")).(context2.Context) | ||
|
|
There was a problem hiding this comment.
The use of reflection to handle context in dataSourceKeepAlive function raises concerns about potential side effects. Verify the necessity and correctness of this approach.
This reverts commit 0a3c464.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1978 +/- ##
===================================================
- Coverage 50.41387% 42.68385% -7.73003%
===================================================
Files 404 124 -280
Lines 28028 9233 -18795
Branches 307 0 -307
===================================================
- Hits 14130 3941 -10189
+ Misses 12509 4828 -7681
+ Partials 1389 464 -925
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
Description
As part of golang/go#65363 attempt to upgrade
terraform-provider-google. This involves some unsafe ops, may revert laterSummary by CodeRabbit
transport.Configinstead ofgoogle.Config, enhancing compatibility and code maintainability.