Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make run requests more stable #378

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Make run requests more stable #378

merged 2 commits into from
Sep 20, 2024

Conversation

kthomas
Copy link
Contributor

@kthomas kthomas commented Sep 20, 2024

Make run requests behave "more synchronously" and increase default agent handshake timeout.

@kthomas kthomas requested a review from a team as a code owner September 20, 2024 01:36
bruth
bruth reviewed Sep 20, 2024
View reviewed changes
Copy link
Contributor

@bruth bruth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions and one comment. It would be helpful to understand the correlation of these changes to how it makes the run request more stable. Is there a test that can be written to demonstrate this before and after?

agent/agent.go Show resolved Hide resolved
internal/node/controlapi.go Show resolved Hide resolved
internal/node/controlapi.go Show resolved Hide resolved
nex/runner.go Show resolved Hide resolved
@kthomas kthomas merged commit 19586ad into main Sep 20, 2024
8 checks passed
@kthomas kthomas deleted the fix/run-requests branch September 20, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@autodidaddict autodidaddict autodidaddict left review comments

@bruth bruth bruth left review comments

@jordan-rash jordan-rash jordan-rash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kthomas @bruth @autodidaddict @jordan-rash