Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extracts wasm and v8 workload executors into their own separate binary plugins #367

Closed
wants to merge 2 commits into from

Conversation

autodidaddict
Copy link
Contributor

This closes #363 , which switches from using Go-native plugins to simple binary plugins.

@autodidaddict autodidaddict requested a review from a team as a code owner August 25, 2024 23:36
@autodidaddict autodidaddict marked this pull request as draft August 25, 2024 23:36
@autodidaddict
Copy link
Contributor Author

Still have a bunch to do here as well as a lot of cleanup. Just checking this into a draft PR so I don't lose it all accidentally :)

@autodidaddict
Copy link
Contributor Author

autodidaddict commented Aug 25, 2024

Things that still need to be done:

  • make sure the rootfs stuff works by adding the wasm and v8 binaries to /usr/local/bin
  • make sure node config defaults agent plugin path to /usr/local/bin
  • finish messaging host service wasm client
  • add and finish http client host service wasm client
  • add documentation Pr to docs.nats.io containing new docs on wasm type
  • explore a way to make it so the wasm runner is a single process with multiple modules rather than creating 1 process per module
  • look into doing the same for v8

If I can't find a good way to to avoid spawning an 18MB (release build binary for Rust runner) per function, then this entire refactor might not be worth it and we might want to look at things from a different perspective. Of course, if we're running inside firecracker then we're forced to do process-per-function anyway (which leads to another tangent about maybe dedicating certain nex nodes to functions and others to native, so the function nodes can run out of sandbox)

@kthomas kthomas closed this Sep 26, 2024
@kthomas kthomas deleted the feat/binary_workload_runners branch September 26, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch from Go native plugins to external binary plugins
2 participants