Skip to content

Conversation

@oscarbenjamin
Copy link
Collaborator

References to other Issues or PRs

Backport of #23693

Brief description of what is fixed or changed

Other comments

Release Notes

  • core
    • A bug preventing the use of the old assumptions under evaluate(False) was fixed.

@sympy-bot
Copy link

sympy-bot commented Mar 11, 2023

Hi, I am the SymPy bot. I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

  • core
    • A bug preventing the use of the old assumptions under evaluate(False) was fixed. (#24895 by @oscarbenjamin)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.12.

Click here to see the pull request description that was parsed.
<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->

Backport of https://github.com/sympy/sympy/pull/23693

#### Brief description of what is fixed or changed


#### Other comments


#### Release Notes

<!-- Write the release notes for this release below between the BEGIN and END
statements. The basic format is a bulleted list with the name of the subpackage
and the release note for this PR. For example:

* solvers
  * Added a new solver for logarithmic equations.

* functions
  * Fixed a bug with log of integers. Formerly, `log(-x)` incorrectly gave `-log(x)`.

* physics.units
  * Corrected a semantical error in the conversion between volt and statvolt which
    reported the volt as being larger than the statvolt.

or if no release note(s) should be included use:

NO ENTRY

See https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more
information on how to write release notes. The bot will check your release
notes automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* core
   * A bug preventing the use of the old assumptions under evaluate(False) was fixed.
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@oscarbenjamin oscarbenjamin added this to the SymPy 1.12 milestone Mar 11, 2023
@oscarbenjamin oscarbenjamin changed the title Pr assumptions backport Backport of assumptions under evaluate=False fix Mar 11, 2023
@oscarbenjamin oscarbenjamin reopened this Mar 11, 2023
@github-actions
Copy link

github-actions bot commented Mar 11, 2023

Benchmark results from GitHub Actions

Lower numbers are good, higher numbers are bad. A ratio less than 1
means a speed up and greater than 1 means a slowdown. Green lines
beginning with + are slowdowns (the PR is slower then master or
master is slower than the previous release). Red lines beginning
with - are speedups.

Significantly changed benchmark results (PR vs master)

· Did not find results for commit upstream/master

Significantly changed benchmark results (master vs previous release)

       before           after         ratio
     [41d90958]       [311c94b8]
     <sympy-1.11.1^0>                 
-         979±2μs        588±0.8μs     0.60  solve.TimeSparseSystem.time_linear_eq_to_matrix(10)
-        2.79±0ms         1.09±0ms     0.39  solve.TimeSparseSystem.time_linear_eq_to_matrix(20)
-     5.57±0.01ms         1.58±0ms     0.28  solve.TimeSparseSystem.time_linear_eq_to_matrix(30)

Full benchmark results can be found as artifacts in GitHub Actions
(click on checks at the top of the PR).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants