Skip to content

Conversation

@sylee957
Copy link
Member

References to other Issues or PRs

Fixes #15109

Brief description of what is fixed or changed

Other comments

Release Notes

  • matrices
    • BREAKING: Removed deprecated functions a2idx and classof from sympy.matrices. This had been deprecated and giving out DeprecationWarning since SymPy 1.3.

@sylee957 sylee957 added the Deprecation Removal Tracks the removal of a deprecated feature. See github.com/sympy/sympy/wiki/Deprecating-policy label Jan 13, 2023
@sympy-bot
Copy link

sympy-bot commented Jan 13, 2023

Hi, I am the SymPy bot (v169). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

  • matrices
    • BREAKING: Removed deprecated functions a2idx and classof from sympy.matrices. This had been deprecated and giving out DeprecationWarning since SymPy 1.3. (#24513 by @sylee957)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.12.

Click here to see the pull request description that was parsed.
<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->
Fixes #15109

#### Brief description of what is fixed or changed


#### Other comments


#### Release Notes

<!-- Write the release notes for this release below between the BEGIN and END
statements. The basic format is a bulleted list with the name of the subpackage
and the release note for this PR. For example:

* solvers
  * Added a new solver for logarithmic equations.

* functions
  * Fixed a bug with log of integers.

or if no release note(s) should be included use:




See https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more
information on how to write release notes. The bot will check your release
notes automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
- matrices
  - BREAKING: Removed deprecated functions `a2idx` and `classof` from `sympy.matrices`. This had been deprecated and giving out `DeprecationWarning` since SymPy 1.3.
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@sylee957 sylee957 closed this Jan 14, 2023
@sylee957 sylee957 reopened this Jan 14, 2023
@github-actions
Copy link

Benchmark results from GitHub Actions

Lower numbers are good, higher numbers are bad. A ratio less than 1
means a speed up and greater than 1 means a slowdown. Green lines
beginning with + are slowdowns (the PR is slower then master or
master is slower than the previous release). Red lines beginning
with - are speedups.

Significantly changed benchmark results (PR vs master)

Significantly changed benchmark results (master vs previous release)

       before           after         ratio
     [41d90958]       [f3b2342e]
     <sympy-1.11.1^0>                 
+     1.17±0.04ms       1.93±0.2ms     1.65  solve.TimeRationalSystemSymbol.time_solve(1)
-      3.46±0.3ms      1.54±0.06ms     0.45  solve.TimeSparseSystem.time_linear_eq_to_matrix(20)
-      7.38±0.3ms      2.38±0.09ms     0.32  solve.TimeSparseSystem.time_linear_eq_to_matrix(30)

Full benchmark results can be found as artifacts in GitHub Actions
(click on checks at the top of the PR).

@oscarbenjamin oscarbenjamin merged commit 3f707f9 into sympy:master Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Deprecation Removal Tracks the removal of a deprecated feature. See github.com/sympy/sympy/wiki/Deprecating-policy

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecate classof() and a2idx() in matrices.py

3 participants