Skip to content

ENH: drop validation of transformations in parse_expr to save time when called in intensive loops #23804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2022
Merged

ENH: drop validation of transformations in parse_expr to save time when called in intensive loops #23804

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .mailmap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,6 +431,7 @@ Christophe Saint-Jean <christophe.saint-jean@univ-lr.fr>
Christopher Dembia <cld72@cornell.edu>
Christopher J. Wright <cjwright4242gh@gmail.com>
Clemens Novak <clemens@familie-novak.net>
Clément M.T. Robert <cr52@protonmail.com>
Coder-RG <rgoel1999@gmail.com> Rishabh Goel <rgoel1999@gmail.com>
Cody Herbst <cyherbst@gmail.com>
Colin B. Macdonald <cbm@m.fsf.org>
Expand Down
18 changes: 2 additions & 16 deletions sympy/parsing/sympy_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,8 @@
from sympy.assumptions.ask import AssumptionKeys
from sympy.core.basic import Basic
from sympy.core import Symbol
from sympy.core.function import arity, Function
from sympy.utilities.iterables import iterable
from sympy.utilities.misc import filldedent, func_name
from sympy.core.function import Function
from sympy.utilities.misc import func_name
from sympy.functions.elementary.miscellaneous import Max, Min


Expand Down Expand Up @@ -1069,19 +1068,6 @@ def parse_expr(s: str, local_dict: Optional[DICT] = None,
raise ValueError('unknown transformation group name')
else:
_transformations = transformations
if _transformations:
if not iterable(_transformations):
raise TypeError(
'`transformations` should be a list of functions.')
for _ in _transformations:
if not callable(_):
raise TypeError(filldedent('''
expected a function in `transformations`,
not %s''' % func_name(_)))
if arity(_) != 3:
raise TypeError(filldedent('''
a transformation should be function that
takes 3 arguments'''))

code = stringify_expr(s, local_dict, global_dict, _transformations)

Expand Down