parsing(c_parser): added support for unary operators and outermost parenthesized expression #19140

smitgajjar · 2020-04-17T18:00:50Z

References to other Issues or PRs

Brief description of what is fixed or changed

Added support for unary operators: unary plus(+), unary minus(-), pre/post increment(++), pre/post decrement(--) and logical NOT(!)
Added support for parenthesized expression
Added corresponding tests

Other comments

Dereferencing operator(*), Address operator(&) and bitwise NOT(~) are the unary operators that have not been implemented because of unavailability of such nodes or classes in SymPy
If unary operators are the children of binary operator in AST, it is not possible to parse yet!

Release Notes

parsing
- added support for unary operators: unary plus(+), unary minus(-), pre/post increment(++), pre/post decrement(--) and logical NOT(!) in C parser
- added support for parenthesized expression in C parser

sympy-bot · 2020-04-17T18:00:51Z

✅

Hi, I am the SymPy bot (v158). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

parsing
- added support for unary operators: unary plus(+), unary minus(-), pre/post increment(++), pre/post decrement(--) and logical NOT(!) in C parser (#19140 by @smitgajjar)
- added support for parenthesized expression in C parser (#19140 by @smitgajjar)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.6.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->

#### Brief description of what is fixed or changed
- Added support for unary operators: unary plus(`+`), unary minus(`-`), pre/post increment(`++`), pre/post decrement(`--`) and logical NOT(`!`)
- Added support for parenthesized expression
- Added corresponding tests

#### Other comments
- Dereferencing operator(`*`), Address operator(`&`) and bitwise NOT(`~`) are the unary operators that have not been implemented because of unavailability of such nodes or classes in SymPy
- If unary operators are the children of binary operator in AST, it is not possible to parse yet!

#### Release Notes

<!-- Write the release notes for this release below. See
https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information
on how to write release notes. The bot will check your release notes
automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
- parsing
    - added support for unary operators: unary plus(`+`), unary minus(`-`), pre/post increment(`++`), pre/post decrement(`--`) and logical NOT(`!`) in C parser
    - added support for parenthesized expression in C parser
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

codecov · 2020-04-17T20:19:22Z

Codecov Report

Merging #19140 into master will decrease coverage by 0.056%.
The diff coverage is 0.000%.

@@              Coverage Diff              @@
##            master    #19140       +/-   ##
=============================================
- Coverage   75.709%   75.652%   -0.057%     
=============================================
  Files          650       651        +1     
  Lines       169166    169384      +218     
  Branches     39909     39985       +76     
=============================================
+ Hits        128075    128144       +69     
- Misses       35494     35632      +138     
- Partials      5597      5608       +11

smitgajjar · 2020-04-21T10:48:22Z

Please review @Sc0rpi0n101 @certik

sympy/parsing/c/c_parser.py

Sc0rpi0n101

Looks good.
Is there anything else left to be done here?

smitgajjar · 2020-04-24T16:14:52Z

No. It is better to merge now, though I wanted to parse unary operators which are children of binary operators. But, using operator precedence parsing, it seems difficult to achieve.

certik

Looks ok to me.

sympy/parsing/c/c_parser.py

Sc0rpi0n101 · 2020-04-25T16:22:20Z

Also, can you add some tests for errorneous behaviour to see if the errors are raised correctly.

smitgajjar · 2020-04-25T16:24:45Z

Sure! working on it now... :)

smitgajjar · 2020-04-25T16:39:24Z

Should I write tests for binary operators and var decl also in this PR? I didn't write those for raising exceptions in earlier PR

Sc0rpi0n101 · 2020-04-25T18:11:46Z

Should I write tests for binary operators and var decl also in this PR? I didn't write those for raising exceptions in earlier PR

Yeah, sure. It'd be great if you can do that.

smitgajjar · 2020-04-27T07:33:05Z

ping

Sc0rpi0n101

LGTM
Can you squash your commits now?

smitgajjar · 2020-04-27T18:45:17Z

Sure!

sympy/parsing/c/c_parser.py

smitgajjar · 2020-04-28T15:00:41Z

If there is anything else, do comment. Otherwise it is good to go now...

sympy/parsing/tests/test_c_parser.py

- Added support for unary operators: - unary plus(+), unary minus(-), pre/post increment(++), pre/post decrement(--) and logical NOT(!) - Added support for parenthesized expression - Added corresponding tests - Added tests for unary operators - Added tests for parenthesized expression - Added tests for Exceptions raised in parsing binary operators, variable declarations and unary operators - Improved error messages of Exceptions raised in parsing binary operators, variable declarations and unary operators Other notes: - Dereferencing operator(*), Address operator(&) and bitwise NOT(~) are the unary operators that have not been implemented because of unavailability of such nodes or classes in SymPy - If unary operators are the children of binary operator in AST, it is not possible to parse yet!

Sc0rpi0n101 · 2020-04-29T16:33:21Z

Merging it now. Thank you for the contribution.

Abdullahjavednesar added the parsing label Apr 18, 2020

Sc0rpi0n101 reviewed Apr 21, 2020

View reviewed changes

smitgajjar force-pushed the unary_op branch from 77de4b2 to 543111f Compare April 21, 2020 22:18

smitgajjar requested a review from Sc0rpi0n101 April 23, 2020 11:42

Sc0rpi0n101 reviewed Apr 24, 2020

View reviewed changes

certik approved these changes Apr 24, 2020

View reviewed changes

Sc0rpi0n101 reviewed Apr 25, 2020

View reviewed changes

sympy/parsing/c/c_parser.py Outdated Show resolved Hide resolved

sympy/parsing/c/c_parser.py Outdated Show resolved Hide resolved

sympy/parsing/c/c_parser.py Outdated Show resolved Hide resolved

smitgajjar requested a review from Sc0rpi0n101 April 26, 2020 10:43

Sc0rpi0n101 approved these changes Apr 27, 2020

View reviewed changes

smitgajjar force-pushed the unary_op branch 2 times, most recently from 1d1cf48 to 04d463c Compare April 27, 2020 19:20

czgdp1807 reviewed Apr 28, 2020

View reviewed changes

sympy/parsing/c/c_parser.py Outdated Show resolved Hide resolved

czgdp1807 reviewed Apr 28, 2020

View reviewed changes

sympy/parsing/c/c_parser.py Outdated Show resolved Hide resolved

Sc0rpi0n101 reviewed Apr 29, 2020

View reviewed changes

sympy/parsing/tests/test_c_parser.py Outdated Show resolved Hide resolved

smitgajjar force-pushed the unary_op branch from ac37296 to a453ab0 Compare April 29, 2020 07:34

Sc0rpi0n101 merged commit 591a62f into sympy:master Apr 29, 2020

smitgajjar deleted the unary_op branch April 29, 2020 16:34

Uh oh!

parsing(c_parser): added support for unary operators and outermost parenthesized expression #19140

parsing(c_parser): added support for unary operators and outermost parenthesized expression #19140

Uh oh!

Conversation

smitgajjar commented Apr 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

References to other Issues or PRs

Brief description of what is fixed or changed

Other comments

Release Notes

Uh oh!

sympy-bot commented Apr 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Apr 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

smitgajjar commented Apr 21, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Sc0rpi0n101 left a comment

Choose a reason for hiding this comment

Uh oh!

smitgajjar commented Apr 24, 2020

Uh oh!

certik left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Sc0rpi0n101 commented Apr 25, 2020

Uh oh!

smitgajjar commented Apr 25, 2020

Uh oh!

smitgajjar commented Apr 25, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Sc0rpi0n101 commented Apr 25, 2020

Uh oh!

smitgajjar commented Apr 27, 2020

Uh oh!

Sc0rpi0n101 left a comment

Choose a reason for hiding this comment

Uh oh!

smitgajjar commented Apr 27, 2020

Uh oh!

Uh oh!

Uh oh!

smitgajjar commented Apr 28, 2020

Uh oh!

Uh oh!

Sc0rpi0n101 commented Apr 29, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

smitgajjar commented Apr 17, 2020 •

edited

Loading

sympy-bot commented Apr 17, 2020 •

edited

Loading

codecov bot commented Apr 17, 2020 •

edited

Loading

smitgajjar commented Apr 25, 2020 •

edited

Loading