Skip to content

Conversation

@sylee957
Copy link
Member

References to other Issues or PRs

Brief description of what is fixed or changed

IdentityFunction is inherited from Lambda, but printing is not done properly

Other comments

Release Notes

  • printing
    • Fixed IdentityFunction printing for LaTeX.

@sympy-bot
Copy link

sympy-bot commented Mar 31, 2020

Hi, I am the SymPy bot (v158). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

  • printing

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.6.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->


#### Brief description of what is fixed or changed

IdentityFunction is inherited from Lambda, but printing is not done properly

#### Other comments


#### Release Notes

<!-- Write the release notes for this release below. See
https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information
on how to write release notes. The bot will check your release notes
automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
- printing
  - Fixed IdentityFunction printing for LaTeX.
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

r"\left( \left( x, \ y\right) \mapsto x + 1 \right)"

assert latex(Lambda(x, x)) == \
r"\left( x \mapsto x + 1 \right)"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it not just be x rather than x + 1?

@codecov
Copy link

codecov bot commented Mar 31, 2020

Codecov Report

Merging #19032 into master will decrease coverage by 0.026%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##            master   #19032       +/-   ##
============================================
- Coverage   75.777%   75.75%   -0.027%     
============================================
  Files          647      648        +1     
  Lines       168623   168798      +175     
  Branches     39734    39786       +52     
============================================
+ Hits        127778   127866       +88     
- Misses       35280    35366       +86     
- Partials      5565     5566        +1

@sylee957 sylee957 merged commit 0389684 into sympy:master Mar 31, 2020
@sylee957 sylee957 deleted the fix_latex_identityfunction branch March 31, 2020 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants