Skip to content

Conversation

@sava-1729
Copy link
Contributor

@sava-1729 sava-1729 commented Mar 29, 2020

References to other Issues or PR

Fixes #18999
(partially)

Brief description of what is fixed or changed

is_finite_set was not implemented in class Range. It is now.

Other comments

Release Notes

  • sets
    • Added is_finite_set property in class Range

@sympy-bot
Copy link

sympy-bot commented Mar 29, 2020

Hi, I am the SymPy bot (v158). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.6.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PR
Fixes #18999 
(partially)
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->


#### Brief description of what is fixed or changed
is_finite_set was not implemented in class Range. It is now.

#### Other comments


#### Release Notes

<!-- Write the release notes for this release below. See
https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information
on how to write release notes. The bot will check your release notes
automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* sets
  *  Added is_finite_set property in class Range
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@codecov
Copy link

codecov bot commented Mar 30, 2020

Codecov Report

Merging #19016 into master will increase coverage by 0.123%.
The diff coverage is 100%.

@@              Coverage Diff              @@
##            master    #19016       +/-   ##
=============================================
+ Coverage   75.663%   75.786%   +0.123%     
=============================================
  Files          647       647               
  Lines       168511    168636      +125     
  Branches     39704     39739       +35     
=============================================
+ Hits        127501    127804      +303     
+ Misses       35453     35269      -184     
- Partials      5557      5563        +6

@sylee957 sylee957 merged commit 88b55b9 into sympy:master Mar 30, 2020
@sava-1729 sava-1729 deleted the adding-is_finite_set-to-Range branch April 1, 2020 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

is_finite_set property not implemented for Range

3 participants