Series: Resolves ValueError during limit evaluation #18978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Hi, I am the SymPy bot (v158). I'm here to help you write a release notes entry. Please read the guide on how to write release notes. Your release notes are in good order. Here is what the release notes will look like:
This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.6. Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it. Click here to see the pull request description that was parsed.
Update The release notes on the wiki have been updated. |
Contributor
Author
|
This is not timing out on my machine. |
jksuom
reviewed
Mar 28, 2020
Co-Authored-By: Kalevi Suominen <jksuom@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #18978 +/- ##
============================================
+ Coverage 64.32% 75.751% +11.43%
============================================
Files 647 647
Lines 168592 168615 +23
Branches 39725 39732 +7
============================================
+ Hits 108439 127728 +19289
+ Misses 53996 35326 -18670
+ Partials 6157 5561 -596 |
Member
|
Thanks, looks good. |
Collaborator
|
The test added here hangs intermittently on Python 3.5: This leads to sporadic Travis failures. I can only reproduce this on 3.5 and it only failed on Travis for 3.5. That would suggest that dict ordering plays a role in the non-determinism. |
Collaborator
|
If the cause of the hang can not be identified quickly then it would be better to xfail the test on Python 3.5 as it will interfere with other PRs. |
Member
|
During the Travis build of #18754 there was a failing test related to the issue resolved. See : https://travis-ci.org/github/sympy/sympy/jobs/668013022?utm_medium=notification&utm_source=github_status |
Contributor
Author
|
Can you please elaborate on the issue a bit more? Why is this hanging on python 3.5? |
Collaborator
|
It is the same failure as seen on Travis in the first commit of this PR. Python 3.5 has non-deterministic dict-ordering so somewhere there is likely to be a code-path that iterates over a dict and hangs depending on the order of the items from the dict. |
Contributor
Author
|
Okay, so what could be a possible solution. |
Collaborator
Identify and fix the cause of the hang or xfail/skip the test |
oscarbenjamin
added a commit
to oscarbenjamin/sympy
that referenced
this pull request
Mar 28, 2020
The test added in sympy#18978 hangs intermittently on Python 3.5. This commit XFAILS that test until the cause of the hang can be identified because it is causing many failed builds on master.
Collaborator
|
I've opened #18990 to XFAIL the test that was added here. I don't know whether this means that the issue closed by this PR should be reopened or whether a new issue should be opened instead. |
Contributor
Author
|
Contributor
Author
|
This is the problem, without any added simplification, the limit is evaluated properly on python 3.5, but not on python 3.7 |
Collaborator
|
I think it's best to either comment on the re-opened issue or close that and open a new issue. |
Contributor
Author
|
okay will comment on the re-opened issue |
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #14811
First of all, it no longer raises any exception as mentioned in the issue.
But, the actual issue is that it is
returned unevaluated due to a ValueError.Brief description of what is fixed or changed
Previously:
A bit of simplification was missing in
limitinf() function of gruntz.pywhich was causingValueErrorand thus, the result was an unevaluated form.Now this evaluates correctly:
Other Comments
Regression Test has been added.
Release Notes
limitinf() function of gruntz.pyresolvingValueError