Skip to content

Conversation

@asmeurer
Copy link
Member

It's basically been public API for a while, since it's the only way to access
the advanced parsing features like the input transformers.

I've not added the transformers themselves. They can still be accessed from
the sympy_parser submodule. It seems to me that adding them to init.py as
well would pollute the namespace, although I don't feel strongly about it.

References to other Issues or PRs

Brief description of what is fixed or changed

Other comments

Release Notes

  • parsing
    • parse_expr can now be imported directly from sympy (from sympy import parse_expr). The various parsing transformers should still be imported from sympy.parsing.sympy_parser.

It's basically been public API for a while, since it's the only way to access
the advanced parsing features like the input transformers.

I've not added the transformers themselves. They can still be accessed from
the sympy_parser submodule. It seems to me that adding them to __init__.py as
well would pollute the namespace, although I don't feel strongly about it.
@sympy-bot
Copy link

sympy-bot commented Dec 18, 2019

Hi, I am the SymPy bot (v149). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

  • parsing
    • parse_expr can now be imported directly from sympy (from sympy import parse_expr). The various parsing transformers should still be imported from sympy.parsing.sympy_parser. (#18074 by @asmeurer)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.6.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

It's basically been public API for a while, since it's the only way to access
the advanced parsing features like the input transformers.

I've not added the transformers themselves. They can still be accessed from
the sympy_parser submodule. It seems to me that adding them to __init__.py as
well would pollute the namespace, although I don't feel strongly about it.

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234". See
https://github.com/blog/1506-closing-issues-via-pull-requests . Please also
write a comment on that issue linking back to this pull request once it is
open. -->


#### Brief description of what is fixed or changed


#### Other comments


#### Release Notes

<!-- Write the release notes for this release below. See
https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information
on how to write release notes. The bot will check your release notes
automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
- parsing
  - `parse_expr` can now be imported directly from sympy (`from sympy import parse_expr`). The various parsing transformers should still be imported from `sympy.parsing.sympy_parser`. 
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@codecov
Copy link

codecov bot commented Dec 18, 2019

Codecov Report

Merging #18074 into master will increase coverage by 0.017%.
The diff coverage is 100%.

@@              Coverage Diff              @@
##            master    #18074       +/-   ##
=============================================
+ Coverage   74.863%   74.881%   +0.017%     
=============================================
  Files          640       641        +1     
  Lines       166561    166564        +3     
  Branches     39179     39179               
=============================================
+ Hits        124694    124725       +31     
+ Misses       36347     36315       -32     
- Partials      5520      5524        +4

@oscarbenjamin oscarbenjamin merged commit 2d3ca2a into sympy:master Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants