Skip to content

Conversation

@Sc0rpi0n101
Copy link
Member

References to other Issues or PRs

Related Issue: #16563
Rebased version of #17171

Brief description of what is fixed or changed

Fortran parser for sympy using the codegen AST nodes
The parser can currently only parse variable and function definitions, assignments and basic binary operations for now due to the limitations in the lfortran ASR and codegen AST.

Other comments

Release Notes

  • parsing
    • Added a new Parser for parsing Fortran source code
    • Added SymPyExpression to handle parsed SymPy expressions

Nikhil Maan and others added 3 commits August 6, 2019 22:37
* Added Fortran parser using lfortran
* Created fortran parsing module
* set up import_module for lfortran
* Modified parser to use codegen AST for output
* Added sym_expr module
* Added documentation refence for the module
* Set up Travis for the parser
* Added documentation and examples for all the modules
* Added tests for the parser and tested on Travis
* Set up Travis and fix any build errors
@sympy-bot
Copy link

sympy-bot commented Aug 6, 2019

Hi, I am the SymPy bot (v147). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.5.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234". See
https://github.com/blog/1506-closing-issues-via-pull-requests . Please also
write a comment on that issue linking back to this pull request once it is
open. -->

Related Issue: #16563
Rebased version of #17171 

#### Brief description of what is fixed or changed

Fortran parser for sympy using the codegen AST nodes
The parser can currently only parse variable and function definitions, assignments and basic binary operations for now due to the limitations in the lfortran ASR and codegen AST.

#### Other comments


#### Release Notes

<!-- Write the release notes for this release below. See
https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information
on how to write release notes. The bot will check your release notes
automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* parsing
  * Added a new Parser for parsing Fortran source code
  * Added SymPyExpression to handle parsed SymPy expressions
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@certik
Copy link
Member

certik commented Aug 6, 2019

Thanks @Sc0rpi0n101. If tests pass, then I think we can merge it, so that it's in, and we can improve upon it later.

@Sc0rpi0n101
Copy link
Member Author

@certik Looks like all the tests passed.

@certik certik merged commit 277d34d into sympy:master Aug 6, 2019
@certik
Copy link
Member

certik commented Aug 6, 2019

Thanks. I am going to merge this. We can now build upon this. Thanks for your work on this PR!

@codecov
Copy link

codecov bot commented Aug 6, 2019

Codecov Report

Merging #17356 into master will increase coverage by 8.275%.
The diff coverage is 0%.

@@              Coverage Diff              @@
##            master    #17356       +/-   ##
=============================================
+ Coverage   66.257%   74.533%   +8.275%     
=============================================
  Files          628       631        +3     
  Lines       162911    163076      +165     
  Branches     38231     38271       +40     
=============================================
+ Hits        107941    121546    +13605     
+ Misses       49623     36137    -13486     
- Partials      5347      5393       +46

1 similar comment
@codecov
Copy link

codecov bot commented Aug 6, 2019

Codecov Report

Merging #17356 into master will increase coverage by 8.275%.
The diff coverage is 0%.

@@              Coverage Diff              @@
##            master    #17356       +/-   ##
=============================================
+ Coverage   66.257%   74.533%   +8.275%     
=============================================
  Files          628       631        +3     
  Lines       162911    163076      +165     
  Branches     38231     38271       +40     
=============================================
+ Hits        107941    121546    +13605     
+ Misses       49623     36137    -13486     
- Partials      5347      5393       +46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants